From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Don't leave gdb instance running after function_range
Date: Fri, 24 Sep 2021 09:56:33 -0400 [thread overview]
Message-ID: <16c2b84f-d92c-4f8d-b8ab-800f237e551e@polymtl.ca> (raw)
In-Reply-To: <c14984f7-526d-7d27-a0f0-5e7f46632fb9@suse.de>
On 2021-09-24 8:34 a.m., Tom de Vries wrote:
> [ Re: [PATCH][gdb/testsuite] Replace prepare_for_testing with
> build_executable ]
>
> On 9/23/21 11:43 PM, Tom de Vries wrote:
>> I found a problem in cpp-linkage-name.exp. The test passes, but the gdb
>> commands execute on a lingering gdb instance started by function_range,
>> so I had to fix that first (by adding gdb_exit at the end of
>> function_range) to trigger the FAIL introduced by the script. I've
>> removed the change in that test-case, and similar cases, and am
>> currently retesting.
>
> I've factored this out as a separate patch.
>
> Any comments?
>
> Thanks,
> - Tom
>
That LGTM, thanks.
Simon
next prev parent reply other threads:[~2021-09-24 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 22:49 [PATCH][gdb/testsuite] Replace prepare_for_testing with build_executable Tom de Vries via Gdb-patches
2021-09-23 15:12 ` Simon Marchi via Gdb-patches
2021-09-23 21:43 ` Tom de Vries via Gdb-patches
2021-09-24 12:34 ` [PATCH][gdb/testsuite] Don't leave gdb instance running after function_range Tom de Vries via Gdb-patches
2021-09-24 13:56 ` Simon Marchi via Gdb-patches [this message]
2021-09-24 14:10 ` [PATCH][gdb/testsuite] Replace prepare_for_testing with build_executable Pedro Alves
2021-09-24 19:40 ` Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16c2b84f-d92c-4f8d-b8ab-800f237e551e@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox