From: Pedro Alves <pedro@palves.net>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Replace prepare_for_testing with build_executable
Date: Fri, 24 Sep 2021 15:10:09 +0100 [thread overview]
Message-ID: <0e6640be-a6f2-b08c-d12c-c7fe73273d25@palves.net> (raw)
In-Reply-To: <20210917224909.GA15407@delia>
On 2021-09-17 11:49 p.m., Tom de Vries via Gdb-patches wrote:
> diff --git a/gdb/testsuite/gdb.trace/qtro.exp b/gdb/testsuite/gdb.trace/qtro.exp
> index 91a6612fb10..8b538e8c249 100644
> --- a/gdb/testsuite/gdb.trace/qtro.exp
> +++ b/gdb/testsuite/gdb.trace/qtro.exp
> @@ -22,7 +22,7 @@ load_lib trace-support.exp
>
> standard_testfile
>
> -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nopie}]} {
> +if {[build_executable "failed to prepare" $testfile $srcfile {debug nopie}]} {
> return -1
> }
> clean_restart $testfile
Well, cases like the above would be better handled by removing the clean_restart call.
next prev parent reply other threads:[~2021-09-24 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 22:49 Tom de Vries via Gdb-patches
2021-09-23 15:12 ` Simon Marchi via Gdb-patches
2021-09-23 21:43 ` Tom de Vries via Gdb-patches
2021-09-24 12:34 ` [PATCH][gdb/testsuite] Don't leave gdb instance running after function_range Tom de Vries via Gdb-patches
2021-09-24 13:56 ` Simon Marchi via Gdb-patches
2021-09-24 14:10 ` Pedro Alves [this message]
2021-09-24 19:40 ` [PATCH][gdb/testsuite] Replace prepare_for_testing with build_executable Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e6640be-a6f2-b08c-d12c-c7fe73273d25@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox