From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XkJ+GlDcTWHpOQAAWB0awg (envelope-from ) for ; Fri, 24 Sep 2021 10:10:24 -0400 Received: by simark.ca (Postfix, from userid 112) id 59EE41EE25; Fri, 24 Sep 2021 10:10:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 99E681EDDB for ; Fri, 24 Sep 2021 10:10:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28057385802E for ; Fri, 24 Sep 2021 14:10:23 +0000 (GMT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by sourceware.org (Postfix) with ESMTPS id AEB853858402 for ; Fri, 24 Sep 2021 14:10:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AEB853858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id t18so28016377wrb.0 for ; Fri, 24 Sep 2021 07:10:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a5eKcNuLzLii0DO6EV6CEmFfX+VW9k668MV/+8zBEzw=; b=Sy+eCBAgzBK7GGaK0h1mfckJ/4H5SlnqJpMSYyYa4LfmP/Q7oQO9EC9mdjyi1C9afn XXiCRStNzGPzCC4OkF/q+3Yh5SC+0qDxZQW+xNFDHduCYRNg2WHs/flIHNI0THmbUvpk miotFqfoxm7nkCZxP2i0jZ5A5oqP8Ki3dCEW2zGSSfw+VmHCXlNtaXLQIQq8Kw+OWZxg 2/rgmR3RokT85Pdz6twLePMf8ZDGv3wEpdZ8t7VvQmelSNi/O208PVp6tXwEmZlyLzcx 00Cmh/1hi+FUix1hQ32C78alK7PzwQpNOeIpikGqBLG2oHf7FTnIpvSBVdDA1i4QrhW7 W5xA== X-Gm-Message-State: AOAM532RIY9qknrUfl4XoAu2e89vI3eYaEvitadBQmnWFD8o6anPq5ow 5B6COlQ1KTKnbSyo2ilPpTk3vruBbdnElA== X-Google-Smtp-Source: ABdhPJylfyJuRlO4TzukEbGJhbxl6htQa0cpCIibrJFzMxc0/EsXev4RH6A5p1D0iCTErAab78MOAA== X-Received: by 2002:a1c:21c3:: with SMTP id h186mr2308645wmh.89.1632492611042; Fri, 24 Sep 2021 07:10:11 -0700 (PDT) Received: from [192.168.0.201] (bl22-100-144.dsl.telepac.pt. [2.83.100.144]) by smtp.gmail.com with ESMTPSA id q10sm8330835wmq.12.2021.09.24.07.10.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 07:10:10 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Replace prepare_for_testing with build_executable From: Pedro Alves To: Tom de Vries , gdb-patches@sourceware.org References: <20210917224909.GA15407@delia> Message-ID: <0e6640be-a6f2-b08c-d12c-c7fe73273d25@palves.net> Date: Fri, 24 Sep 2021 15:10:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210917224909.GA15407@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-09-17 11:49 p.m., Tom de Vries via Gdb-patches wrote: > diff --git a/gdb/testsuite/gdb.trace/qtro.exp b/gdb/testsuite/gdb.trace/qtro.exp > index 91a6612fb10..8b538e8c249 100644 > --- a/gdb/testsuite/gdb.trace/qtro.exp > +++ b/gdb/testsuite/gdb.trace/qtro.exp > @@ -22,7 +22,7 @@ load_lib trace-support.exp > > standard_testfile > > -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nopie}]} { > +if {[build_executable "failed to prepare" $testfile $srcfile {debug nopie}]} { > return -1 > } > clean_restart $testfile Well, cases like the above would be better handled by removing the clean_restart call.