From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eBX9Li/ZTWFGOQAAWB0awg (envelope-from ) for ; Fri, 24 Sep 2021 09:57:03 -0400 Received: by simark.ca (Postfix, from userid 112) id A73411EE25; Fri, 24 Sep 2021 09:57:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 771A91EDDB for ; Fri, 24 Sep 2021 09:56:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0A8EA3858015 for ; Fri, 24 Sep 2021 13:56:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A8EA3858015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632491818; bh=PwmGmJFEm8vVIfzFhg7EcLWJYjf8KwdtBIiPqAM6lg0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=tcuHTmDmGwa8Wykq6GwUKrFvt7wOiUpPcX3Jm3vfmlYLwoyh1rB/4f2fEoFdNWc2w W7mPiZ+sL8TP1HXMzGlSvB6y9LfXAJLegZp0ucS/QmYXuJRrGF1rOmx5LMkdER3iyo cyiOo0vn2M9TgY/lzp4nzv0/alh9JTuDtD/9PKZA= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 862763858402 for ; Fri, 24 Sep 2021 13:56:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 862763858402 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18ODuYGo005136 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Sep 2021 09:56:38 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18ODuYGo005136 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0C6EE1EDDB; Fri, 24 Sep 2021 09:56:34 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Don't leave gdb instance running after function_range To: Tom de Vries , gdb-patches@sourceware.org References: <20210917224909.GA15407@delia> <5b995a81-afd0-adbb-1639-b1aecfa4d8e7@polymtl.ca> <13a04bcb-6842-a5ce-5457-ed4510a0a79b@suse.de> Message-ID: <16c2b84f-d92c-4f8d-b8ab-800f237e551e@polymtl.ca> Date: Fri, 24 Sep 2021 09:56:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 24 Sep 2021 13:56:34 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-09-24 8:34 a.m., Tom de Vries wrote: > [ Re: [PATCH][gdb/testsuite] Replace prepare_for_testing with > build_executable ] > > On 9/23/21 11:43 PM, Tom de Vries wrote: >> I found a problem in cpp-linkage-name.exp. The test passes, but the gdb >> commands execute on a lingering gdb instance started by function_range, >> so I had to fix that first (by adding gdb_exit at the end of >> function_range) to trigger the FAIL introduced by the script. I've >> removed the change in that test-case, and similar cases, and am >> currently retesting. > > I've factored this out as a separate patch. > > Any comments? > > Thanks, > - Tom > That LGTM, thanks. Simon