* [RFA] sh-tdep.c: Fix double handling in LE mode
@ 2004-03-25 17:10 Corinna Vinschen
2004-04-29 12:44 ` Corinna Vinschen
2004-06-01 16:07 ` Elena Zannoni
0 siblings, 2 replies; 4+ messages in thread
From: Corinna Vinschen @ 2004-03-25 17:10 UTC (permalink / raw)
To: gdb-patches
Hi,
the below pretty trivial patch fixes two FAILs on SH4 and SH4a in
little endian mode.
Ok, to apply?
Corinna
* sh-tdep.c (sh3e_sh4_store_return_value): Correctly store
double values in little endian mode.
Index: sh-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-tdep.c,v
retrieving revision 1.167
diff -u -p -r1.167 sh-tdep.c
--- sh-tdep.c 8 Mar 2004 10:18:13 -0000 1.167
+++ sh-tdep.c 25 Mar 2004 17:07:51 -0000
@@ -1147,7 +1147,11 @@ sh3e_sh4_store_return_value (struct type
int len = TYPE_LENGTH (type);
int i, regnum = FP0_REGNUM;
for (i = 0; i < len; i += 4)
- regcache_raw_write (regcache, regnum++, (char *) valbuf + i);
+ if (TARGET_BYTE_ORDER == BFD_ENDIAN_LITTLE)
+ regcache_raw_write (regcache, regnum++,
+ (char *) valbuf + len - 4 - i);
+ else
+ regcache_raw_write (regcache, regnum++, (char *) valbuf + i);
}
else
sh_default_store_return_value (type, regcache, valbuf);
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] sh-tdep.c: Fix double handling in LE mode
2004-03-25 17:10 [RFA] sh-tdep.c: Fix double handling in LE mode Corinna Vinschen
@ 2004-04-29 12:44 ` Corinna Vinschen
2004-06-01 16:07 ` Elena Zannoni
1 sibling, 0 replies; 4+ messages in thread
From: Corinna Vinschen @ 2004-04-29 12:44 UTC (permalink / raw)
To: gdb-patches
Ping?
On Mar 25 18:10, Corinna Vinschen wrote:
> Hi,
>
> the below pretty trivial patch fixes two FAILs on SH4 and SH4a in
> little endian mode.
>
> Ok, to apply?
>
> Corinna
>
> * sh-tdep.c (sh3e_sh4_store_return_value): Correctly store
> double values in little endian mode.
>
> Index: sh-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/sh-tdep.c,v
> retrieving revision 1.167
> diff -u -p -r1.167 sh-tdep.c
> --- sh-tdep.c 8 Mar 2004 10:18:13 -0000 1.167
> +++ sh-tdep.c 25 Mar 2004 17:07:51 -0000
> @@ -1147,7 +1147,11 @@ sh3e_sh4_store_return_value (struct type
> int len = TYPE_LENGTH (type);
> int i, regnum = FP0_REGNUM;
> for (i = 0; i < len; i += 4)
> - regcache_raw_write (regcache, regnum++, (char *) valbuf + i);
> + if (TARGET_BYTE_ORDER == BFD_ENDIAN_LITTLE)
> + regcache_raw_write (regcache, regnum++,
> + (char *) valbuf + len - 4 - i);
> + else
> + regcache_raw_write (regcache, regnum++, (char *) valbuf + i);
> }
> else
> sh_default_store_return_value (type, regcache, valbuf);
>
> --
> Corinna Vinschen
> Cygwin Developer
> Red Hat, Inc.
--
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] sh-tdep.c: Fix double handling in LE mode
2004-03-25 17:10 [RFA] sh-tdep.c: Fix double handling in LE mode Corinna Vinschen
2004-04-29 12:44 ` Corinna Vinschen
@ 2004-06-01 16:07 ` Elena Zannoni
2004-06-03 11:47 ` Corinna Vinschen
1 sibling, 1 reply; 4+ messages in thread
From: Elena Zannoni @ 2004-06-01 16:07 UTC (permalink / raw)
To: gdb-patches
Corinna Vinschen writes:
> Hi,
>
> the below pretty trivial patch fixes two FAILs on SH4 and SH4a in
> little endian mode.
>
> Ok, to apply?
>
> Corinna
>
> * sh-tdep.c (sh3e_sh4_store_return_value): Correctly store
> double values in little endian mode.
>
ok
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] sh-tdep.c: Fix double handling in LE mode
2004-06-01 16:07 ` Elena Zannoni
@ 2004-06-03 11:47 ` Corinna Vinschen
0 siblings, 0 replies; 4+ messages in thread
From: Corinna Vinschen @ 2004-06-03 11:47 UTC (permalink / raw)
To: gdb-patches
On Jun 1 12:00, Elena Zannoni wrote:
> Corinna Vinschen writes:
> > * sh-tdep.c (sh3e_sh4_store_return_value): Correctly store
> > double values in little endian mode.
>
> ok
Thanks, applied.
Corinna
--
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-06-03 11:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-25 17:10 [RFA] sh-tdep.c: Fix double handling in LE mode Corinna Vinschen
2004-04-29 12:44 ` Corinna Vinschen
2004-06-01 16:07 ` Elena Zannoni
2004-06-03 11:47 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox