From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9106 invoked by alias); 29 Apr 2004 12:44:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9039 invoked from network); 29 Apr 2004 12:44:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 29 Apr 2004 12:44:36 -0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3TCiYKG013835 for ; Thu, 29 Apr 2004 08:44:35 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3TCiYw25862 for ; Thu, 29 Apr 2004 08:44:34 -0400 Received: from cygbert.vinschen.de (vpn50-31.rdu.redhat.com [172.16.50.31]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i3TCiXC17327 for ; Thu, 29 Apr 2004 05:44:33 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id EBEA65811D; Thu, 29 Apr 2004 14:44:26 +0200 (CEST) Date: Thu, 29 Apr 2004 12:44:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-tdep.c: Fix double handling in LE mode Message-ID: <20040429124426.GH17535@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040325171024.GZ17229@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040325171024.GZ17229@cygbert.vinschen.de> User-Agent: Mutt/1.4.2i X-RedHat-Spam-Score: 0 X-SW-Source: 2004-04/txt/msg00665.txt.bz2 Ping? On Mar 25 18:10, Corinna Vinschen wrote: > Hi, > > the below pretty trivial patch fixes two FAILs on SH4 and SH4a in > little endian mode. > > Ok, to apply? > > Corinna > > * sh-tdep.c (sh3e_sh4_store_return_value): Correctly store > double values in little endian mode. > > Index: sh-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/sh-tdep.c,v > retrieving revision 1.167 > diff -u -p -r1.167 sh-tdep.c > --- sh-tdep.c 8 Mar 2004 10:18:13 -0000 1.167 > +++ sh-tdep.c 25 Mar 2004 17:07:51 -0000 > @@ -1147,7 +1147,11 @@ sh3e_sh4_store_return_value (struct type > int len = TYPE_LENGTH (type); > int i, regnum = FP0_REGNUM; > for (i = 0; i < len; i += 4) > - regcache_raw_write (regcache, regnum++, (char *) valbuf + i); > + if (TARGET_BYTE_ORDER == BFD_ENDIAN_LITTLE) > + regcache_raw_write (regcache, regnum++, > + (char *) valbuf + len - 4 - i); > + else > + regcache_raw_write (regcache, regnum++, (char *) valbuf + i); > } > else > sh_default_store_return_value (type, regcache, valbuf); > > -- > Corinna Vinschen > Cygwin Developer > Red Hat, Inc. -- Corinna Vinschen Cygwin Co-Project Leader Red Hat, Inc.