Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nick@nick.uklinux.net>
To: gdb-patches@sources.redhat.com
Subject: RFA (?) Annotate Level 3 patch
Date: Tue, 05 Aug 2003 20:10:00 -0000	[thread overview]
Message-ID: <16176.3560.65649.7079@nick.uklinux.net> (raw)


The annotation frame-begin is not needed, per se, by Emacs (gdb-ui.el) but it
is used to determine that the I/O for the subprocess is now GDB, not the
program being debugged i.e as a stopped annotation. In many cases there is
another annotation e.g breakpoint to tell Emacs this. However, in some cases,
e.g after `finish' or `return', frame-begin is the first `stopping' annotation
that GDB issues before printing (out frame details).

So I propose the patch below. It means that the stopped annotation gets printed
twice but that doesn't matter to Emacs. It's not elegant but, hey, it works!

I think Emacs is the only application that is interested in level 3
annotations so could "-gnuemacs" be made an alias option for "-annotate=3"?
From GDB's point of view this would discourage new applications form using
it. From Emacs point of view, it would legitimise changes that we would wish
to make.

Nick



--- annotate.c.~1.5.60.1.~	2003-07-29 14:35:47.000000000 +0100
+++ annotate.c	2003-08-04 19:44:02.000000000 +0100
@@ -436,6 +436,7 @@
       print_address_numeric (pc, 0, gdb_stdout);
       printf_filtered ("\n");
     }
+  if (annotation_level == 3) printf_filtered ("\n\032\032stopped\n");
 }
 
 void


             reply	other threads:[~2003-08-05 20:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-05 20:10 Nick Roberts [this message]
2004-01-27 20:28 ` Andrew Cagney
2004-01-29  0:20   ` Annotations Nick Roberts
2004-02-02 22:09   ` RFA (?) Annotate Level 3 patch Nick Roberts
2004-02-10 23:40     ` Andrew Cagney
2004-02-12 21:53       ` Nick Roberts
2004-02-12 22:34         ` Bob Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16176.3560.65649.7079@nick.uklinux.net \
    --to=nick@nick.uklinux.net \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox