* [patch/testcase] fix gdb.objc/basicclass.exp
@ 2003-07-04 3:07 Kei Sakamoto
2003-07-07 14:13 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Kei Sakamoto @ 2003-07-04 3:07 UTC (permalink / raw)
To: gdb-patches
The attached patch fixes gdb.objc.basicclass.exp.
The current test always fail with sim because of libobjc's error.
(gdb) PASS: gdb.objc/basicclass.exp: continue until method breakpoint
run
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program:
/project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.objc/basicclass
Virtual memory exhausted
*** EXIT code 4242
Program exited with code 0157255.
[Switching to process 0]
(gdb) FAIL: gdb.objc/basicclass.exp: resetting breakpoints when rerunning
I assume this is not libobjc's bug. Please tell me if my
assumption is wrong.
Anyway, I inserted load command before run command. I checked
this patch with m32r-elf, arm-elf, and sh-elf.
Kei
===
2003-07-04 Kei Sakamoto <sakamoto.kei@renesas.com>
* gdb.objc/basicclass.exp: Execute load command before re-running
program in case of sim.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch/testcase] fix gdb.objc/basicclass.exp
2003-07-04 3:07 [patch/testcase] fix gdb.objc/basicclass.exp Kei Sakamoto
@ 2003-07-07 14:13 ` Daniel Jacobowitz
2003-07-08 0:58 ` Kei Sakamoto
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-07-07 14:13 UTC (permalink / raw)
To: Kei Sakamoto; +Cc: gdb-patches
On Fri, Jul 04, 2003 at 12:09:36PM +0900, Kei Sakamoto wrote:
> The attached patch fixes gdb.objc.basicclass.exp.
>
> The current test always fail with sim because of libobjc's error.
>
> (gdb) PASS: gdb.objc/basicclass.exp: continue until method breakpoint
> run
> The program being debugged has been started already.
> Start it from the beginning? (y or n) y
> Starting program:
> /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.objc/basicclass
> Virtual memory exhausted
>
> *** EXIT code 4242
>
> Program exited with code 0157255.
> [Switching to process 0]
> (gdb) FAIL: gdb.objc/basicclass.exp: resetting breakpoints when rerunning
>
> I assume this is not libobjc's bug. Please tell me if my
> assumption is wrong.
>
> Anyway, I inserted load command before run command. I checked
> this patch with m32r-elf, arm-elf, and sh-elf.
You missed the patch - would you mind posting it?
>
> Kei
>
> ===
>
> 2003-07-04 Kei Sakamoto <sakamoto.kei@renesas.com>
>
> * gdb.objc/basicclass.exp: Execute load command before re-running
> program in case of sim.
>
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch/testcase] fix gdb.objc/basicclass.exp
2003-07-07 14:13 ` Daniel Jacobowitz
@ 2003-07-08 0:58 ` Kei Sakamoto
2003-07-08 2:26 ` Doug Evans
2003-08-28 19:37 ` Daniel Jacobowitz
0 siblings, 2 replies; 6+ messages in thread
From: Kei Sakamoto @ 2003-07-08 0:58 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
> On Fri, Jul 04, 2003 at 12:09:36PM +0900, Kei Sakamoto wrote:
> > The attached patch fixes gdb.objc.basicclass.exp.
> >
> > The current test always fail with sim because of libobjc's error.
> >
> > (gdb) PASS: gdb.objc/basicclass.exp: continue until method breakpoint
> > run
> > The program being debugged has been started already.
> > Start it from the beginning? (y or n) y
> > Starting program:
> > /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.objc/basicclass
> > Virtual memory exhausted
> >
> > *** EXIT code 4242
> >
> > Program exited with code 0157255.
> > [Switching to process 0]
> > (gdb) FAIL: gdb.objc/basicclass.exp: resetting breakpoints when rerunning
> >
> > I assume this is not libobjc's bug. Please tell me if my
> > assumption is wrong.
> >
> > Anyway, I inserted load command before run command. I checked
> > this patch with m32r-elf, arm-elf, and sh-elf.
>
> You missed the patch - would you mind posting it?
I'm sorry about that. This is the patch.
Kei
[-- Attachment #2: basicclass.exp.patch --]
[-- Type: application/octet-stream, Size: 457 bytes --]
--- insight-20030703.orig/src/gdb/testsuite/gdb.objc/basicclass.exp Tue Jun 24 05:20:31 2003
+++ insight-20030703/src/gdb/testsuite/gdb.objc/basicclass.exp Mon Jul 7 12:15:23 2003
@@ -125,6 +125,10 @@
#
# Test resetting breakpoints when re-running program
#
+if { [target_info protocol] == "sim" } {
+ send_gdb "load\n"
+ exp_continue
+}
send_gdb "run\n"
gdb_expect {
-re "The program .* has been started already.*y or n. $" {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch/testcase] fix gdb.objc/basicclass.exp
2003-07-08 0:58 ` Kei Sakamoto
@ 2003-07-08 2:26 ` Doug Evans
2003-07-08 19:45 ` Michael Snyder
2003-08-28 19:37 ` Daniel Jacobowitz
1 sibling, 1 reply; 6+ messages in thread
From: Doug Evans @ 2003-07-08 2:26 UTC (permalink / raw)
To: Kei Sakamoto; +Cc: Daniel Jacobowitz, gdb-patches
Kei Sakamoto writes:
> > On Fri, Jul 04, 2003 at 12:09:36PM +0900, Kei Sakamoto wrote:
> > > The attached patch fixes gdb.objc.basicclass.exp.
> > >
> > > The current test always fail with sim because of libobjc's error.
> > >
> > > (gdb) PASS: gdb.objc/basicclass.exp: continue until method breakpoint
> > > run
> > > The program being debugged has been started already.
> > > Start it from the beginning? (y or n) y
> > > Starting program:
> > > /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.objc/basicclass
> > > Virtual memory exhausted
> > >
> > > *** EXIT code 4242
> > >
> > > Program exited with code 0157255.
> > > [Switching to process 0]
> > > (gdb) FAIL: gdb.objc/basicclass.exp: resetting breakpoints when rerunning
> > >
> > > I assume this is not libobjc's bug. Please tell me if my
> > > assumption is wrong.
> > >
> > > Anyway, I inserted load command before run command. I checked
> > > this patch with m32r-elf, arm-elf, and sh-elf.
> >
> > You missed the patch - would you mind posting it?
>
> I'm sorry about that. This is the patch.
I'm curious. Why is this now necessary?
Way back when run did an implicit load, among other things
(at least for sims I remember).
One can certainly debate what semantics "run" should have.
I like "run" behaving the same across targets (unix, sim, whatever).
"run" might not make much sense to target boards
(including sims emulating target boards).
In such cases I'd argue we shouldn't be using it, rather than
trying to make it work.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch/testcase] fix gdb.objc/basicclass.exp
2003-07-08 2:26 ` Doug Evans
@ 2003-07-08 19:45 ` Michael Snyder
0 siblings, 0 replies; 6+ messages in thread
From: Michael Snyder @ 2003-07-08 19:45 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches, drow
Doug Evans wrote:
> Kei Sakamoto writes:
> > > On Fri, Jul 04, 2003 at 12:09:36PM +0900, Kei Sakamoto wrote:
> > > > The attached patch fixes gdb.objc.basicclass.exp.
> > > >
> > > > The current test always fail with sim because of libobjc's error.
> > > >
> > > > (gdb) PASS: gdb.objc/basicclass.exp: continue until method breakpoint
> > > > run
> > > > The program being debugged has been started already.
> > > > Start it from the beginning? (y or n) y
> > > > Starting program:
> > > > /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.objc/basicclass
> > > > Virtual memory exhausted
> > > >
> > > > *** EXIT code 4242
> > > >
> > > > Program exited with code 0157255.
> > > > [Switching to process 0]
> > > > (gdb) FAIL: gdb.objc/basicclass.exp: resetting breakpoints when rerunning
> > > >
> > > > I assume this is not libobjc's bug. Please tell me if my
> > > > assumption is wrong.
> > > >
> > > > Anyway, I inserted load command before run command. I checked
> > > > this patch with m32r-elf, arm-elf, and sh-elf.
> > >
> > > You missed the patch - would you mind posting it?
> >
> > I'm sorry about that. This is the patch.
>
> I'm curious. Why is this now necessary?
> Way back when run did an implicit load, among other things
> (at least for sims I remember).
Really? I don't remember that. I don't think I'd like it, either.
What if I wanted to patch memory, and then run?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch/testcase] fix gdb.objc/basicclass.exp
2003-07-08 0:58 ` Kei Sakamoto
2003-07-08 2:26 ` Doug Evans
@ 2003-08-28 19:37 ` Daniel Jacobowitz
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-08-28 19:37 UTC (permalink / raw)
To: gdb-patches
On Tue, Jul 08, 2003 at 10:00:43AM +0900, Kei Sakamoto wrote:
> > On Fri, Jul 04, 2003 at 12:09:36PM +0900, Kei Sakamoto wrote:
> > > The attached patch fixes gdb.objc.basicclass.exp.
> > >
> > > The current test always fail with sim because of libobjc's error.
> > >
> > > (gdb) PASS: gdb.objc/basicclass.exp: continue until method breakpoint
> > > run
> > > The program being debugged has been started already.
> > > Start it from the beginning? (y or n) y
> > > Starting program:
> > > /project/m32r-tools/insight-20030703/build/gdb/testsuite/gdb.objc/basicclass
> > > Virtual memory exhausted
> > >
> > > *** EXIT code 4242
> > >
> > > Program exited with code 0157255.
> > > [Switching to process 0]
> > > (gdb) FAIL: gdb.objc/basicclass.exp: resetting breakpoints when rerunning
> > >
> > > I assume this is not libobjc's bug. Please tell me if my
> > > assumption is wrong.
> > >
> > > Anyway, I inserted load command before run command. I checked
> > > this patch with m32r-elf, arm-elf, and sh-elf.
> >
> > You missed the patch - would you mind posting it?
>
> I'm sorry about that. This is the patch.
>
> Kei
I've just posted an alternate patch for this, which doesn't hardcode
the string "sim".
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-08-28 19:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-04 3:07 [patch/testcase] fix gdb.objc/basicclass.exp Kei Sakamoto
2003-07-07 14:13 ` Daniel Jacobowitz
2003-07-08 0:58 ` Kei Sakamoto
2003-07-08 2:26 ` Doug Evans
2003-07-08 19:45 ` Michael Snyder
2003-08-28 19:37 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox