Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] fix warning in dwarfread.c
@ 2003-06-26 22:31 Elena Zannoni
  2003-06-27 13:35 ` Elena Zannoni
  0 siblings, 1 reply; 2+ messages in thread
From: Elena Zannoni @ 2003-06-26 22:31 UTC (permalink / raw)
  To: gdb-patches


I got a warning using gcc 3.3.

elena

2003-06-26  Elena Zannoni  <ezannoni@redhat.com>

        * dwarfread.c (decode_modified_type): Gag new compiler warning.


Index: dwarfread.c
===================================================================
RCS file: /cvs/uberbaum/gdb/dwarfread.c,v
retrieving revision 1.28
diff -u -p -r1.28 dwarfread.c
--- dwarfread.c	23 Jun 2003 19:51:38 -0000	1.28
+++ dwarfread.c	26 Jun 2003 22:29:03 -0000
@@ -3198,8 +3198,12 @@ decode_modified_type (char *modifiers, u
 		     DIE_ID, DIE_NAME);	/* FIXME */
 	  break;
 	default:
-	  if (!(MOD_lo_user <= (unsigned char) modifier
+	  if (!(MOD_lo_user <= (unsigned char) modifier))
+#if 0
+/* This part of the test would always be true, and it triggers a compiler
+   warning.  */
 		&& (unsigned char) modifier <= MOD_hi_user))
+#endif
 	    {
 	      complaint (&symfile_complaints,
 			 "DIE @ 0x%x \"%s\", unknown type modifier %u", DIE_ID,


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix warning in dwarfread.c
  2003-06-26 22:31 [PATCH] fix warning in dwarfread.c Elena Zannoni
@ 2003-06-27 13:35 ` Elena Zannoni
  0 siblings, 0 replies; 2+ messages in thread
From: Elena Zannoni @ 2003-06-27 13:35 UTC (permalink / raw)
  To: gdb-patches

Elena Zannoni writes:
 > 
 > I got a warning using gcc 3.3.
 > 
 > elena
 > 
 > 2003-06-26  Elena Zannoni  <ezannoni@redhat.com>
 > 
 >         * dwarfread.c (decode_modified_type): Gag new compiler warning.
 > 

committed to gdb6 branch and trunk


elena

 > 
 > Index: dwarfread.c
 > ===================================================================
 > RCS file: /cvs/uberbaum/gdb/dwarfread.c,v
 > retrieving revision 1.28
 > diff -u -p -r1.28 dwarfread.c
 > --- dwarfread.c	23 Jun 2003 19:51:38 -0000	1.28
 > +++ dwarfread.c	26 Jun 2003 22:29:03 -0000
 > @@ -3198,8 +3198,12 @@ decode_modified_type (char *modifiers, u
 >  		     DIE_ID, DIE_NAME);	/* FIXME */
 >  	  break;
 >  	default:
 > -	  if (!(MOD_lo_user <= (unsigned char) modifier
 > +	  if (!(MOD_lo_user <= (unsigned char) modifier))
 > +#if 0
 > +/* This part of the test would always be true, and it triggers a compiler
 > +   warning.  */
 >  		&& (unsigned char) modifier <= MOD_hi_user))
 > +#endif
 >  	    {
 >  	      complaint (&symfile_complaints,
 >  			 "DIE @ 0x%x \"%s\", unknown type modifier %u", DIE_ID,


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-06-27 13:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-26 22:31 [PATCH] fix warning in dwarfread.c Elena Zannoni
2003-06-27 13:35 ` Elena Zannoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox