From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10915 invoked by alias); 27 Jun 2003 13:35:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10908 invoked from network); 27 Jun 2003 13:35:12 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 27 Jun 2003 13:35:12 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h5RDZCH23119 for ; Fri, 27 Jun 2003 09:35:12 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5RDZCI21763 for ; Fri, 27 Jun 2003 09:35:12 -0400 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5RDZB219296 for ; Fri, 27 Jun 2003 09:35:11 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id E2A8B2CA3A; Fri, 27 Jun 2003 09:42:00 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16124.18856.343966.180891@localhost.redhat.com> Date: Fri, 27 Jun 2003 13:35:00 -0000 To: gdb-patches@sources.redhat.com Cc: Subject: Re: [PATCH] fix warning in dwarfread.c In-Reply-To: <16123.30184.642647.645807@localhost.redhat.com> References: <16123.30184.642647.645807@localhost.redhat.com> X-SW-Source: 2003-06/txt/msg00812.txt.bz2 Elena Zannoni writes: > > I got a warning using gcc 3.3. > > elena > > 2003-06-26 Elena Zannoni > > * dwarfread.c (decode_modified_type): Gag new compiler warning. > committed to gdb6 branch and trunk elena > > Index: dwarfread.c > =================================================================== > RCS file: /cvs/uberbaum/gdb/dwarfread.c,v > retrieving revision 1.28 > diff -u -p -r1.28 dwarfread.c > --- dwarfread.c 23 Jun 2003 19:51:38 -0000 1.28 > +++ dwarfread.c 26 Jun 2003 22:29:03 -0000 > @@ -3198,8 +3198,12 @@ decode_modified_type (char *modifiers, u > DIE_ID, DIE_NAME); /* FIXME */ > break; > default: > - if (!(MOD_lo_user <= (unsigned char) modifier > + if (!(MOD_lo_user <= (unsigned char) modifier)) > +#if 0 > +/* This part of the test would always be true, and it triggers a compiler > + warning. */ > && (unsigned char) modifier <= MOD_hi_user)) > +#endif > { > complaint (&symfile_complaints, > "DIE @ 0x%x \"%s\", unknown type modifier %u", DIE_ID,