From: Elena Zannoni <ezannoni@redhat.com>
To: muller@cerbere.u-strasbg.fr
Cc: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix an error in value_change_enclosing_type
Date: Tue, 22 Oct 2002 14:42:00 -0000 [thread overview]
Message-ID: <15797.50576.457181.289982@localhost.redhat.com> (raw)
In-Reply-To: <3.0.6.32.20021020235330.00c24478@ics.u-strasbg.fr>
muller@cerbere.u-strasbg.fr writes:
> At 17:05 18/10/2002 -0400, Elena Zannoni wrote:
> >Pierre Muller writes:
> > >
> > >
> > >
> > > the function value_change_enclosing_type
> > > does not set the enlclosing_type field correctly if
> > > the new_encl_type has a bigger length that the value type.
> > >
> > > Its seems quite astonishing that this has not been noticed before,
> > > but I discovered it when trying to get
> > > the fpc-abi.c code to work correctly.
> > >
> >
> >The fix seems OK. However, do you have a small testcase? It would be
> >good to add it to the testsuite.
> Sorry, but I don't have any, because I really don't even know
> if this code is ever executed for C code. It is for
> Free Pascal generated code, that is how I discovered that bug.
> But I can't add tests with Free Pascal anyhow.
>
Oh, ok.
> >Does this fix changes the results for the already existing tests?
>
> Sorry, but I never worked with the testsuite,
> so I can't answer this question.
>
Could you run make check in your gdb/testsuite directory in the build
tree? All I meant is, whether or not the test results are different
before and after your change.
thanks
Elena
next prev parent reply other threads:[~2002-10-22 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-07 4:37 Pierre Muller
2002-10-18 14:08 ` Elena Zannoni
2002-10-20 14:55 ` muller
2002-10-22 14:42 ` Elena Zannoni [this message]
2002-10-29 1:07 ` Pierre Muller
2002-11-03 16:09 ` Elena Zannoni
2002-11-05 0:26 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15797.50576.457181.289982@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=muller@cerbere.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox