From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15013 invoked by alias); 22 Oct 2002 21:42:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15006 invoked from network); 22 Oct 2002 21:42:15 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Oct 2002 21:42:15 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9MLKtw30070 for ; Tue, 22 Oct 2002 17:20:55 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MLgFf17312 for ; Tue, 22 Oct 2002 17:42:15 -0400 Received: from localhost.redhat.com (IDENT:q7KTNcxIoopS1t0gScW8wNaH0klCVzDi@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MLgDw20424; Tue, 22 Oct 2002 17:42:13 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 4042DFF79; Tue, 22 Oct 2002 17:39:29 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15797.50576.457181.289982@localhost.redhat.com> Date: Tue, 22 Oct 2002 14:42:00 -0000 To: muller@cerbere.u-strasbg.fr Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix an error in value_change_enclosing_type In-Reply-To: <3.0.6.32.20021020235330.00c24478@ics.u-strasbg.fr> References: <5.0.2.1.2.20021007132114.01e66260@ics.u-strasbg.fr> <3.0.6.32.20021020235330.00c24478@ics.u-strasbg.fr> X-SW-Source: 2002-10/txt/msg00429.txt.bz2 muller@cerbere.u-strasbg.fr writes: > At 17:05 18/10/2002 -0400, Elena Zannoni wrote: > >Pierre Muller writes: > > > > > > > > > > > > the function value_change_enclosing_type > > > does not set the enlclosing_type field correctly if > > > the new_encl_type has a bigger length that the value type. > > > > > > Its seems quite astonishing that this has not been noticed before, > > > but I discovered it when trying to get > > > the fpc-abi.c code to work correctly. > > > > > > >The fix seems OK. However, do you have a small testcase? It would be > >good to add it to the testsuite. > Sorry, but I don't have any, because I really don't even know > if this code is ever executed for C code. It is for > Free Pascal generated code, that is how I discovered that bug. > But I can't add tests with Free Pascal anyhow. > Oh, ok. > >Does this fix changes the results for the already existing tests? > > Sorry, but I never worked with the testsuite, > so I can't answer this question. > Could you run make check in your gdb/testsuite directory in the build tree? All I meant is, whether or not the test results are different before and after your change. thanks Elena