Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] PPC ABI compliance fix
Date: Fri, 22 Mar 2002 12:06:00 -0000	[thread overview]
Message-ID: <15515.36530.35292.601677@localhost.redhat.com> (raw)
In-Reply-To: <3C9B8B66.2090403@cygnus.com>

Andrew Cagney writes:
 > > Index: ppc-linux-tdep.c
 > > ===================================================================
 > > RCS file: /cvs/uberbaum/gdb/ppc-linux-tdep.c,v
 > > retrieving revision 1.13
 > > diff -u -r1.13 ppc-linux-tdep.c
 > > --- ppc-linux-tdep.c	2002/02/24 22:31:19	1.13
 > > +++ ppc-linux-tdep.c	2002/03/22 18:48:39
 > > @@ -414,6 +414,14 @@
 > >     it may be used generically by ports which use either the SysV ABI or
 > >     the EABI */
 > >  
 > > +/* Structures 8 bytes or less long are returned in the r3 & r4
 > > +   registers, according to the SYSV ABI. */
 > > +int
 > > +ppc_sysv_abi_use_struct_convention (int gcc_p, struct type *value_type)
 > > +{
 > > +  return (TYPE_LENGTH (value_type) > 8);
 > > +}
 > > +
 > >  /* round2 rounds x up to the nearest multiple of s assuming that s is a
 > >     power of 2 */
 > 
 > Should this live in rs6000-tdep.c?

Yes, There is a FIXME about that in the file. I am not sure why
sysv_push_arguments is in that file as well. I didn't want to change
it in case there was some real technical problem.

Maybe Kevin knows why?

Elena


 > 
 > enjoy,
 > Andrew
 > 
 > 


  reply	other threads:[~2002-03-22 20:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-22 11:28 Elena Zannoni
2002-03-22 11:52 ` Andrew Cagney
2002-03-22 12:06   ` Elena Zannoni [this message]
2002-03-22 12:37     ` Kevin Buettner
2002-03-22 12:47 ` Kevin Buettner
2002-03-22 13:41   ` Elena Zannoni
2002-03-22 14:01 ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15515.36530.35292.601677@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox