Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] PPC ABI compliance fix
Date: Fri, 22 Mar 2002 13:41:00 -0000	[thread overview]
Message-ID: <15515.42195.51105.78562@localhost.redhat.com> (raw)
In-Reply-To: <1020322204651.ZM27792@localhost.localdomain>

Kevin Buettner writes:
 > On Mar 22,  2:28pm, Elena Zannoni wrote:
 > 
 > > Back in November, gcc changed the way structures <= 8 bytes are
 > > returned on the PPC. The change was made to be compliant with the
 > > SVR4 ABI.
 > > 
 > > http://gcc.gnu.org/ml/gcc-patches/2001-11/msg01468.html
 > > 
 > > The abi specifies that such structures are passed in r3 and r4.
 > > Bigger structures are passed in memory.
 > > 
 > > Gcc was passing every structure in memory.  The change was made for
 > > embedded targets, but not for natives (PowerPC Linux, NetBSD, and
 > > FreeBSD).
 > > 
 > > Of course this change breaks binary compatibility with older gcc's.
 > > Not sure what to do about that, if anything, the case it covers is a
 > > corner case, anyway.
 > 
 > Hmm...  I have a hunch that, eventually, the natives will need to
 > change too.
 > 

Gcc is explicitly disabling ABI compliance for the natives. I think
Aldy asked to the gcc mailing list if he could change at least Linux,
and there was a loud 'No'.

 > For now though, your change is okay.
 > 
 > (Alternately, we could take a really hard nosed stance and implement
 > the ABI exactly as written and just put up with the failures.)
 > 

Ironically enough the gcc implementation is not correct, yet. It
screws up where exactly in r3 and r4 it puts the structure if the
structure is strictly less than 8 bytes. :-( 
For instances 5 characters are stored like

R3        R4
. . . h   e l l o

Instead of 

R3        R4
h e l l   o . . .


I thought Aldy was taking care of this, but he has gone on vacation.

Elena


 > Kevin


  reply	other threads:[~2002-03-22 21:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-22 11:28 Elena Zannoni
2002-03-22 11:52 ` Andrew Cagney
2002-03-22 12:06   ` Elena Zannoni
2002-03-22 12:37     ` Kevin Buettner
2002-03-22 12:47 ` Kevin Buettner
2002-03-22 13:41   ` Elena Zannoni [this message]
2002-03-22 14:01 ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15515.42195.51105.78562@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox