From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3161 invoked by alias); 22 Mar 2002 20:06:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3058 invoked from network); 22 Mar 2002 20:06:43 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 22 Mar 2002 20:06:43 -0000 Received: from localhost.redhat.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA28884; Fri, 22 Mar 2002 12:06:34 -0800 (PST) Received: by localhost.redhat.com (Postfix, from userid 469) id 3A15511429; Fri, 22 Mar 2002 15:06:10 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15515.36530.35292.601677@localhost.redhat.com> Date: Fri, 22 Mar 2002 12:06:00 -0000 To: Andrew Cagney Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] PPC ABI compliance fix In-Reply-To: <3C9B8B66.2090403@cygnus.com> References: <15515.34258.778318.466752@localhost.redhat.com> <3C9B8B66.2090403@cygnus.com> X-Mailer: VM 7.00 under Emacs 20.7.1 X-SW-Source: 2002-03/txt/msg00430.txt.bz2 Andrew Cagney writes: > > Index: ppc-linux-tdep.c > > =================================================================== > > RCS file: /cvs/uberbaum/gdb/ppc-linux-tdep.c,v > > retrieving revision 1.13 > > diff -u -r1.13 ppc-linux-tdep.c > > --- ppc-linux-tdep.c 2002/02/24 22:31:19 1.13 > > +++ ppc-linux-tdep.c 2002/03/22 18:48:39 > > @@ -414,6 +414,14 @@ > > it may be used generically by ports which use either the SysV ABI or > > the EABI */ > > > > +/* Structures 8 bytes or less long are returned in the r3 & r4 > > + registers, according to the SYSV ABI. */ > > +int > > +ppc_sysv_abi_use_struct_convention (int gcc_p, struct type *value_type) > > +{ > > + return (TYPE_LENGTH (value_type) > 8); > > +} > > + > > /* round2 rounds x up to the nearest multiple of s assuming that s is a > > power of 2 */ > > Should this live in rs6000-tdep.c? Yes, There is a FIXME about that in the file. I am not sure why sysv_push_arguments is in that file as well. I didn't want to change it in case there was some real technical problem. Maybe Kevin knows why? Elena > > enjoy, > Andrew > >