From: Zoran Zaric via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>,
Zoran Zaric via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 13/30] Make DWARF evaluator return a single struct value
Date: Tue, 9 Feb 2021 14:55:30 +0000 [thread overview]
Message-ID: <154ba00f-293d-d823-26b2-d3cbddb39f7b@amd.com> (raw)
In-Reply-To: <87v9b2dyzt.fsf@tromey.com>
>
> Zoran> From: Zoran Zaric <zoran.zaric@amd.com>
> Zoran> The patch is addressing the issue of class users writing and reading
> Zoran> the internal data of the dwarf_expr_context class.
>
> Zoran> At this point, all conditions are met for the DWARF evaluator to return
> Zoran> an evaluation result in a form of a single struct value object.
>
> Zoran> gdb/ChangeLog:
>
> Zoran> * dwarf2/expr.c (pieced_value_funcs): Chenge to static
> Zoran> function.
> Zoran> (allocate_piece_closure): Change to static function.
> Zoran> (dwarf_expr_context::fetch_result): New function.
> Zoran> * dwarf2/expr.h (struct piece_closure): Remove declaration.
> Zoran> (struct dwarf_expr_context): fetch_result new declaration.
> Zoran> fetch, fetch_address and fetch_in_stack_memory members move
> Zoran> to private.
> Zoran> (allocate_piece_closure): Remove.
> Zoran> * dwarf2/frame.c (execute_stack_op): Change to use
> Zoran> fetch_result.
> Zoran> * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Change to use
> Zoran> fetch_result.
> Zoran> (dwarf2_locexpr_baton_eval): Change to use fetch_result.
>
> Thanks, this looks good.
> I guess this is where invalid_synthetic_pointer is used.
> I don't mind if you just leave the previous patch as-is.
>
> Tom
>
Thank you.
I was trying really hard to not have these silly patch split mistakes,
but somehow there is always a few that slip through.
Zoran
next prev parent reply other threads:[~2021-02-09 14:55 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 19:00 [PATCH 00/30] Allow location description on the DWARF stack Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 01/30] Replace the symbol needs evaluator with a parser Zoran Zaric via Gdb-patches
2021-01-21 21:16 ` Tom Tromey
2021-01-21 21:48 ` Zoran Zaric via Gdb-patches
2021-02-23 14:15 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 02/30] Move frame context info to dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:23 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 03/30] Remove get_frame_cfa from dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:23 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 04/30] Move compilation unit info to dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:28 ` Tom Tromey
2021-02-23 14:21 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 05/30] Move dwarf_call " Zoran Zaric via Gdb-patches
2021-01-21 21:30 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 06/30] Move get_object_address " Zoran Zaric via Gdb-patches
2021-01-21 21:31 ` Tom Tromey
2021-02-23 14:33 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 07/30] Move read_mem " Zoran Zaric via Gdb-patches
2021-01-21 21:34 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 08/30] Move push_dwarf_reg_entry_value to expr.c Zoran Zaric via Gdb-patches
2021-01-21 21:35 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 09/30] Inline get_reg_value method of dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:36 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 10/30] Remove empty frame and full evaluators Zoran Zaric via Gdb-patches
2021-01-21 21:37 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 11/30] Merge evaluate_for_locexpr_baton evaluator Zoran Zaric via Gdb-patches
2021-02-08 21:21 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 12/30] Move piece_closure and its support to expr.c Zoran Zaric via Gdb-patches
2021-02-08 21:32 ` Tom Tromey
2021-02-09 14:53 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 13/30] Make DWARF evaluator return a single struct value Zoran Zaric via Gdb-patches
2021-02-08 21:35 ` Tom Tromey
2021-02-09 14:55 ` Zoran Zaric via Gdb-patches [this message]
2021-02-09 17:13 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 14/30] Simplify dwarf_expr_context class interface Zoran Zaric via Gdb-patches
2021-02-08 21:38 ` Tom Tromey
2021-02-09 14:56 ` Zoran Zaric via Gdb-patches
2021-02-23 14:38 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 15/30] Add as_lval argument to expression evaluator Zoran Zaric via Gdb-patches
2021-02-08 21:41 ` Tom Tromey
2021-02-09 15:25 ` Zoran Zaric via Gdb-patches
2021-02-09 20:33 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 16/30] Add new register access interface to expr.c Zoran Zaric via Gdb-patches
2021-02-09 19:37 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 17/30] Add new memory " Zoran Zaric via Gdb-patches
2021-02-09 19:45 ` Tom Tromey
2021-02-23 15:35 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 18/30] Add new classes that model DWARF stack element Zoran Zaric via Gdb-patches
2021-02-08 21:54 ` Tom Tromey
2021-02-09 17:34 ` Zoran Zaric via Gdb-patches
2021-02-09 20:36 ` Tom Tromey
2021-02-09 21:07 ` Tom Tromey
2021-02-09 21:26 ` Zoran Zaric via Gdb-patches
2021-02-23 14:57 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 19/30] Add new location description access interface Zoran Zaric via Gdb-patches
2021-02-08 21:46 ` Tom Tromey
2021-02-09 16:00 ` Zoran Zaric via Gdb-patches
2021-02-09 17:30 ` Zoran Zaric via Gdb-patches
2021-02-23 14:49 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 20/30] Add dwarf_entry factory class to expr.c Zoran Zaric via Gdb-patches
2021-02-09 19:54 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 21/30] Change DWARF stack to use new dwarf_entry classes Zoran Zaric via Gdb-patches
2021-02-09 20:11 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 22/30] Remove dwarf_expr_context from expr.h interface Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 23/30] Rename and update the piece_closure structure Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 24/30] Move read_addr_from_reg function to frame.c Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 25/30] Add frame info check to DW_OP_reg operations Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 26/30] Remove DWARF expression composition check Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 27/30] Add support for any location description in CFI Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 28/30] Add DWARF operations for byte and bit offset Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 29/30] Add support for DW_OP_LLVM_undefined operation Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 30/30] Add support for nested composite locations Zoran Zaric via Gdb-patches
2020-12-08 14:48 ` [PATCH 00/30] Allow location description on the DWARF stack Metzger, Markus T via Gdb-patches
2020-12-08 16:17 ` Simon Marchi via Gdb-patches
2020-12-09 0:30 ` Tye, Tony via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154ba00f-293d-d823-26b2-d3cbddb39f7b@amd.com \
--to=gdb-patches@sourceware.org \
--cc=Zoran.Zaric@amd.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox