From: Tom Tromey <tom@tromey.com>
To: Zoran Zaric via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 17/30] Add new memory access interface to expr.c
Date: Tue, 09 Feb 2021 12:45:18 -0700 [thread overview]
Message-ID: <871rdpc9f5.fsf@tromey.com> (raw)
In-Reply-To: <20201207190031.13341-18-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:18 +0000")
>>>>> "Zoran" == Zoran Zaric via Gdb-patches <gdb-patches@sourceware.org> writes:
Zoran> DWARF expression evaluator is currently using a few different
Zoran> interfaces for memory access: write_memory_with_notification,
Zoran> read_value_memory, read_memory.
Zoran> They all seem incosistent, while some of them even need a struct
Zoran> value typed argument to be present.
Zoran> This patch is simplifying that interface by replacing it with two new
Zoran> low level functions: read_from_memory and write_to_memory.
Zoran> The advantage of this new interface is that it behaves in the same way
Zoran> as the register access interface from the previous patch. Both of these
Zoran> have the same error returning policy, which will be usefull for the
Zoran> following patches.
Is there any way to avoid adding more functions like this?
Like could target_read_memory be used instead?
Zoran> +static void
Zoran> +xfer_from_memory (CORE_ADDR address, gdb_byte *readbuf,
This is a bit misnamed, since "from" implies reading, but really this
does both reading and writing.
Zoran> +static void
Zoran> +write_to_memory (CORE_ADDR address, const gdb_byte *buffer,
Zoran> + size_t length, bool stack, int *unavailable)
Zoran> +{
Zoran> + xfer_from_memory (address, nullptr, buffer, length, stack, unavailable);
Zoran> +
Zoran> + gdb::observers::memory_changed.notify (current_inferior (), address,
Zoran> + length, buffer);
This notifies the observer even if the write fails.
I do wonder, though, why some writes notify the observer and some do
not... looking e.g., at corefile.c:write_memory_unsigned_integer.
Tom
next prev parent reply other threads:[~2021-02-09 19:45 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 19:00 [PATCH 00/30] Allow location description on the DWARF stack Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 01/30] Replace the symbol needs evaluator with a parser Zoran Zaric via Gdb-patches
2021-01-21 21:16 ` Tom Tromey
2021-01-21 21:48 ` Zoran Zaric via Gdb-patches
2021-02-23 14:15 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 02/30] Move frame context info to dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:23 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 03/30] Remove get_frame_cfa from dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:23 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 04/30] Move compilation unit info to dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:28 ` Tom Tromey
2021-02-23 14:21 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 05/30] Move dwarf_call " Zoran Zaric via Gdb-patches
2021-01-21 21:30 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 06/30] Move get_object_address " Zoran Zaric via Gdb-patches
2021-01-21 21:31 ` Tom Tromey
2021-02-23 14:33 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 07/30] Move read_mem " Zoran Zaric via Gdb-patches
2021-01-21 21:34 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 08/30] Move push_dwarf_reg_entry_value to expr.c Zoran Zaric via Gdb-patches
2021-01-21 21:35 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 09/30] Inline get_reg_value method of dwarf_expr_context Zoran Zaric via Gdb-patches
2021-01-21 21:36 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 10/30] Remove empty frame and full evaluators Zoran Zaric via Gdb-patches
2021-01-21 21:37 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 11/30] Merge evaluate_for_locexpr_baton evaluator Zoran Zaric via Gdb-patches
2021-02-08 21:21 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 12/30] Move piece_closure and its support to expr.c Zoran Zaric via Gdb-patches
2021-02-08 21:32 ` Tom Tromey
2021-02-09 14:53 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 13/30] Make DWARF evaluator return a single struct value Zoran Zaric via Gdb-patches
2021-02-08 21:35 ` Tom Tromey
2021-02-09 14:55 ` Zoran Zaric via Gdb-patches
2021-02-09 17:13 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 14/30] Simplify dwarf_expr_context class interface Zoran Zaric via Gdb-patches
2021-02-08 21:38 ` Tom Tromey
2021-02-09 14:56 ` Zoran Zaric via Gdb-patches
2021-02-23 14:38 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 15/30] Add as_lval argument to expression evaluator Zoran Zaric via Gdb-patches
2021-02-08 21:41 ` Tom Tromey
2021-02-09 15:25 ` Zoran Zaric via Gdb-patches
2021-02-09 20:33 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 16/30] Add new register access interface to expr.c Zoran Zaric via Gdb-patches
2021-02-09 19:37 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 17/30] Add new memory " Zoran Zaric via Gdb-patches
2021-02-09 19:45 ` Tom Tromey [this message]
2021-02-23 15:35 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 18/30] Add new classes that model DWARF stack element Zoran Zaric via Gdb-patches
2021-02-08 21:54 ` Tom Tromey
2021-02-09 17:34 ` Zoran Zaric via Gdb-patches
2021-02-09 20:36 ` Tom Tromey
2021-02-09 21:07 ` Tom Tromey
2021-02-09 21:26 ` Zoran Zaric via Gdb-patches
2021-02-23 14:57 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 19/30] Add new location description access interface Zoran Zaric via Gdb-patches
2021-02-08 21:46 ` Tom Tromey
2021-02-09 16:00 ` Zoran Zaric via Gdb-patches
2021-02-09 17:30 ` Zoran Zaric via Gdb-patches
2021-02-23 14:49 ` Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 20/30] Add dwarf_entry factory class to expr.c Zoran Zaric via Gdb-patches
2021-02-09 19:54 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 21/30] Change DWARF stack to use new dwarf_entry classes Zoran Zaric via Gdb-patches
2021-02-09 20:11 ` Tom Tromey
2020-12-07 19:00 ` [PATCH 22/30] Remove dwarf_expr_context from expr.h interface Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 23/30] Rename and update the piece_closure structure Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 24/30] Move read_addr_from_reg function to frame.c Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 25/30] Add frame info check to DW_OP_reg operations Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 26/30] Remove DWARF expression composition check Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 27/30] Add support for any location description in CFI Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 28/30] Add DWARF operations for byte and bit offset Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 29/30] Add support for DW_OP_LLVM_undefined operation Zoran Zaric via Gdb-patches
2020-12-07 19:00 ` [PATCH 30/30] Add support for nested composite locations Zoran Zaric via Gdb-patches
2020-12-08 14:48 ` [PATCH 00/30] Allow location description on the DWARF stack Metzger, Markus T via Gdb-patches
2020-12-08 16:17 ` Simon Marchi via Gdb-patches
2020-12-09 0:30 ` Tye, Tony via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rdpc9f5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox