From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bUz3G26iImCkYAAAWB0awg (envelope-from ) for ; Tue, 09 Feb 2021 09:55:42 -0500 Received: by simark.ca (Postfix, from userid 112) id 6A9971EF4F; Tue, 9 Feb 2021 09:55:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F016A1E590 for ; Tue, 9 Feb 2021 09:55:41 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A73173835421; Tue, 9 Feb 2021 14:55:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A73173835421 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612882541; bh=Js/h9EgsYt7vuXFPaCbUWmQ7GtaXRIEETVnQhVSjmF4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PSirxXtWajmwV/a52kY2d2hAQDlalRRAv23B9p6ElIrsqfnfFBUxv+uvZ5LuM/Dkg zaSBwjcOcoiBllsKHUdzNZDJP+s1riMhjNdbiPHwruyI54hEQilt9q4ZDv6mCJsxQc YS08jn+UaSfymjcQnlwnmHvMSgXyRs/lwRA6HkdI= Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2050.outbound.protection.outlook.com [40.107.244.50]) by sourceware.org (Postfix) with ESMTPS id 61CAB38708C3 for ; Tue, 9 Feb 2021 14:55:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 61CAB38708C3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVDtxHmocpaao4WYngnBQshnybO5dCTuabU1uOMFKWghHW9ZvVsukKRWp+zOEwPa/vAmvFsJlJD423HbO6GkBSYyihC2VDnb5a5/+4kFK7MKjFY74a0OfLz1oIByKbf2NDtMduI5Ey1owXENNNhFpcDZJLX/mb+XvuBtks6Dixf+xYLbtZDghO0ZlLqjNQBX/pB+9jaKNo3uRxbb7fnITx/FqybUGF0CMMuB9EZMG13fIoGtM4P1l4K1MspITmYaup4UmdEY0bj+E/zAmQ7yCJw8UW0B/yV1/99d79r1i4LuaBlvGguKnRk16i+6n04boTvALUULuO3nlZFvQGGNuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Js/h9EgsYt7vuXFPaCbUWmQ7GtaXRIEETVnQhVSjmF4=; b=EnAz61T6ed7adOf2oB6hR6oFD8iNPnbXs4ps8oU+8KcKSXIlw35pNzVm8Ma/hw2aVVZTXWqeZwWa+06pNDJMLBFknVdqIPhXEyKC1RODL6pGYTir1jvTrCeLADGyq/D/dNSyDofYkKbnCyhxLaoUptB3SaUGiSG4FZB3m0cmrQ3NoSXywZrJh9djnqjovWRvX3z911l/JAgs6fEJu3mqY5ST4LxSMD6fEXi20fhZcZi/B8psQMqYQ5hAPm13E7VlbLppCAL3ddRQaYWq6RSU43eTWQyivF5KEYnNcQ9BWa/S6zomUG7nEYzzv4k0RiXTjLIA34oe/qxatHQs8PLdIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB4532.namprd12.prod.outlook.com (2603:10b6:5:2af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20; Tue, 9 Feb 2021 14:55:36 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 14:55:36 +0000 Subject: Re: [PATCH 13/30] Make DWARF evaluator return a single struct value To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-14-Zoran.Zaric@amd.com> <87v9b2dyzt.fsf@tromey.com> Message-ID: <154ba00f-293d-d823-26b2-d3cbddb39f7b@amd.com> Date: Tue, 9 Feb 2021 14:55:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87v9b2dyzt.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:b142:b2da:a877:6c3] X-ClientProxiedBy: AM8P190CA0005.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::10) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:b142:b2da:a877:6c3] (2a00:23c7:5a85:6801:b142:b2da:a877:6c3) by AM8P190CA0005.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20 via Frontend Transport; Tue, 9 Feb 2021 14:55:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f4d628d3-e135-4764-2501-08d8cd0ac1c8 X-MS-TrafficTypeDiagnostic: DM6PR12MB4532: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9v+6WGuW7JFXSCTHadqOTSowzFyrUJviz6yQ1taajcYL/n1QPFu5/e2TLv1gh8jK4Km0u1bmWtSUrjLNBiieaHDgK+NEEmz/dIRTyGaNMWmJtKnOGd7KNY6vF7rbsO+nEde9Ka8JRTRPRYsKmONxtKa8NsmoE8DK+2rqAlC7/KqnmB4kYmK9/gN1pkBEnccF/VAbZR89UGdVa5SWJAKxYwuvr+uDelEqOtE9IBVIkl0bIp+bIChACaEVBYYv3BeVdb4D6kT65Xjl5y2qAfk0ZnITlCFdnzjIDHXI/T6RpRp+DVXTGCcoiAdr3gjFat77v5p6YzYsvi2eHDV/s3gew3CUTOvtRON1kjE1Aq0hVnvBDX560I5iyg2eWfs9oAqqUzjM5nS/lzVSj3NpTm9dmHHx5/++3n10TgcbBnxlf14ChPyVV5WJa+OgnxAiDBks3QcbcnI2NaN1QcrFBslTkac9fUciKQ/lAKCssxvoLpw9gddTuMfREgVFXDZ5ieXz41dqYHoYL1jpPR8ST1prGfODmf2aCF/HrMN0c+dHo3+9dq5nIrCNQE9Wy3OSK49v8pwye//YHEj8eX6buyFhYPndlYB93LZ5XOPjfl7YE+8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(8676002)(478600001)(186003)(16526019)(66946007)(66476007)(83380400001)(86362001)(6486002)(8936002)(66556008)(5660300002)(31696002)(36756003)(316002)(110136005)(2616005)(6666004)(31686004)(2906002)(52116002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bWpQelBaUjVackRPSG9QZ3VGSWhjbzVuOVExdnYyMklKdjFPYkxNUTZtMDd2?= =?utf-8?B?L2RhbWZaWWlkYmhFdlNZMmtOZjZkVW9XOURMK3I0Rk1KejFtMkRzNVhSTG1y?= =?utf-8?B?dXZ4dC8vd2t1NWhONk1KV2RNZkhxbytvNFIrNHg1Wm1yOURjQm8rMnk3ekQr?= =?utf-8?B?bG03ZFBQZGJzeUFCbXFkYkc3UFc1ME1OY1BVaUFZYWFMNEVVRGh2c0o5WTZO?= =?utf-8?B?ZnhkQkhrcDI5WGdweFp6RVc2bE1ad2NrQ1FXN21BdDB2YW1najFDNEZ6RUJM?= =?utf-8?B?NFZwMHlJazhnMjlEY3pjL0xNY0hpREtuNlREMEljSjFGRUVWc0E4b2pCbzMr?= =?utf-8?B?TjNWN2dWRm1NcWE1S0x1dG5IYlRwY1RvR094VDlLQ01Ta0o0aHhXTUlxSXZX?= =?utf-8?B?d0hiQ20wRXlPbmZ4dDZtS3ZNOHg3a0JwYW5LK2Y2Q2V2TE1yaGJFZEREMDR5?= =?utf-8?B?YTRQZHpkSWVWb1dLYWdMMmpWb3VIbXIzaEtLOFZCdXdJY0NuYzltc1o4TDJ5?= =?utf-8?B?eEJJakRNYlNCS2R5Ulk2bW92SWV5UXdIZlZIZTNpcmJqbXFIcVovRlFNQXBP?= =?utf-8?B?OE1xVjZuN29hWEpOaGlWWnZDanZFZlVSWitpdWhBVlkycndRQmQ0OEp6OVg3?= =?utf-8?B?OGNsSncwSmg5Q2RKVGF6U3dFclJiNXAveEtYWWZsd1lPT3hGZEQ1V0ttSmVn?= =?utf-8?B?dTRiVzZGN21sN1lFd1Z2RU5GYW4wdVUvYjRsbXhLM0Zrb3ZmNmlkRk1ETkhF?= =?utf-8?B?YmRBRlhldGdDWVovRERFR0xlZHNndlQ3SVhBd29qRDVsWDRoS3BydW1MWWRL?= =?utf-8?B?RXVBVFJ1cTdNc3hHc0MrM2lQVzMwa3N6WFdmK3orMnllQ1NQRThnaFpiNTV5?= =?utf-8?B?L09QZXVmZk5UL29reGw0TzhxQWY2TExyczMzWmhpV2ZHc1JFQ0pFYzdJdUNS?= =?utf-8?B?YUF0OWhpU2xFUHY4LzlRUDBvenA5YzJCa2szOWJqQi9hWnNiOUw1Ymw4L2Mw?= =?utf-8?B?YTdkckZpNHFYdkNjZnh1dUtCVExobVlhTWhyM09JOWkxVTdDRldjOVM3dWhB?= =?utf-8?B?MmZHalVFajJDOGxxSjd1TEpOR2pmMjBDNHBkKzlrRnhIbDB6by8yM2dWUXl4?= =?utf-8?B?ZUhhaThhRlRxVnJpWG9RRGszaXpLaklGd0pKRmtDbzNHbkRaTi9hMkQ5OVp6?= =?utf-8?B?ZVJSRGZTNVJEc3UrL0JLMC94dFZIT0FLbEhTTkJDUVNIR0Fid0Mvbmh1UFBI?= =?utf-8?B?RHdJcGtiZWRJcXFUY0RDZWZVZWJPSzFJdzZBYS9xYkJlSWxGUWw3S09ycWdk?= =?utf-8?B?UXZadjZKN2QxWWlmdi92bUh1UXBjbm11QWRRR0tjVktTT205OHFkZDlxaGp1?= =?utf-8?B?NVhRaFF6OCtPcUlocmhoSkVxQ2lUdlpwYWI3VGxOR0xpVWJkd0hkS2lDYnRn?= =?utf-8?B?SUFGV2dhOVV4ZUFkaXdIZE42ZjViREl6dHVIY2tPbk1aWnhjMTZCSmlYV2pH?= =?utf-8?B?c095T1VHbkpkUm1zbkoycmdQbWxZQWlaVXp1U0lDcHJMdnV2Q1dOd2VGS2ZF?= =?utf-8?B?RlRFQ0xpQWtHNm92U1FhdjJDU3EycjdZOFlNcnU0aHJHRHdvYS9MVFQzdEQr?= =?utf-8?B?SlVPbHRuSDUzVnVwVFJBM0pRc0NOOFVFM2s3RmxhNG5nL0dadWltV3o3enh1?= =?utf-8?B?aWRaYXYwMCt4U3JlOForbGF5Y0ZZWDZ5MXFUSUlPZWc4eEh4SytSWmFKMVRa?= =?utf-8?B?a3lQWTMxdlVpV1pLcGc0K0kzVEZEL3MxaCtibUhwd1ppMjZ3QUF5cEU1K01W?= =?utf-8?B?eTVtTFVXZmNTWXo3NjAyWVZKTkZFMmxuOWJpQTRRb1Y5ZnRJbzhFbjBJOVpR?= =?utf-8?Q?ONpAAQtAxR4ua?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4d628d3-e135-4764-2501-08d8cd0ac1c8 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 14:55:36.0090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F61/ffFy7eOR1aVbwBEaBNF930w0b5WC98Y+3mg5e6tMuZ0bntsQog1zT9PgqdtHKDtLlblbiwDR+dS62SlsJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4532 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > > Zoran> From: Zoran Zaric > Zoran> The patch is addressing the issue of class users writing and reading > Zoran> the internal data of the dwarf_expr_context class. > > Zoran> At this point, all conditions are met for the DWARF evaluator to return > Zoran> an evaluation result in a form of a single struct value object. > > Zoran> gdb/ChangeLog: > > Zoran> * dwarf2/expr.c (pieced_value_funcs): Chenge to static > Zoran> function. > Zoran> (allocate_piece_closure): Change to static function. > Zoran> (dwarf_expr_context::fetch_result): New function. > Zoran> * dwarf2/expr.h (struct piece_closure): Remove declaration. > Zoran> (struct dwarf_expr_context): fetch_result new declaration. > Zoran> fetch, fetch_address and fetch_in_stack_memory members move > Zoran> to private. > Zoran> (allocate_piece_closure): Remove. > Zoran> * dwarf2/frame.c (execute_stack_op): Change to use > Zoran> fetch_result. > Zoran> * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Change to use > Zoran> fetch_result. > Zoran> (dwarf2_locexpr_baton_eval): Change to use fetch_result. > > Thanks, this looks good. > I guess this is where invalid_synthetic_pointer is used. > I don't mind if you just leave the previous patch as-is. > > Tom > Thank you. I was trying really hard to not have these silly patch split mistakes, but somehow there is always a few that slip through. Zoran