[PATCH] Don't handle unavailable/optimized-out in spu_software_single_step

[PATCH] Don't handle unavailable/optimized-out in spu_software_single_step

[Yao Qi]

When we do software single step, frame is always the innermost one,
so it is impossible to get unavailable/optimized-out errors.

gdb:

2016-11-11  Yao Qi  <yao.qi@linaro.org>

	* spu-tdep.c (spu_software_single_step): Don't call
	get_frame_register_bytes, call get_frame_register_unsigned
	instead.
---
 gdb/spu-tdep.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c
index 5494a93..073be2d 100644
--- a/gdb/spu-tdep.c
+++ b/gdb/spu-tdep.c
@@ -1652,24 +1652,7 @@ spu_software_single_step (struct frame_info *frame)
       if (reg == SPU_PC_REGNUM)
 	target += SPUADDR_ADDR (pc);
       else if (reg != -1)
-	{
-	  int optim, unavail;
-
-	  if (get_frame_register_bytes (frame, reg, 0, 4, buf,
-					 &optim, &unavail))
-	    target += extract_unsigned_integer (buf, 4, byte_order) & -4;
-	  else
-	    {
-	      if (optim)
-		throw_error (OPTIMIZED_OUT_ERROR,
-			     _("Could not determine address of "
-			       "single-step breakpoint."));
-	      if (unavail)
-		throw_error (NOT_AVAILABLE_ERROR,
-			     _("Could not determine address of "
-			       "single-step breakpoint."));
-	    }
-	}
+	target += get_frame_register_unsigned (frame, reg) & -4;
 
       target = target & lslr;
       if (target != next_pc)
-- 
1.9.1

Re: [PATCH] Don't handle unavailable/optimized-out in spu_software_single_step

[Ulrich Weigand]

Yao Qi wrote:

> When we do software single step, frame is always the innermost one,
> so it is impossible to get unavailable/optimized-out errors.
> 
> gdb:
> 
> 2016-11-11  Yao Qi  <yao.qi@linaro.org>
> 
> 	* spu-tdep.c (spu_software_single_step): Don't call
> 	get_frame_register_bytes, call get_frame_register_unsigned
> 	instead.

Looks good to me.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

Re: [PATCH] Don't handle unavailable/optimized-out in spu_software_single_step

[Yao Qi]

On Fri, Nov 11, 2016 at 2:41 PM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
>
> Looks good to me.
>

Patch is pushed in.

-- 
Yao (齐尧)