From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43567 invoked by alias); 11 Nov 2016 14:41:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43551 invoked by uid 89); 11 Nov 2016 14:41:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*x:version, H*UA:version, H*i:sk:1478873, 20161111 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 14:41:13 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uABEccoG128248 for ; Fri, 11 Nov 2016 09:41:12 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 26neh0f329-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 11 Nov 2016 09:41:11 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Nov 2016 14:41:10 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 11 Nov 2016 14:41:08 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1FC031B08067 for ; Fri, 11 Nov 2016 14:43:21 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uABEf78Q12386602 for ; Fri, 11 Nov 2016 14:41:07 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uABEf6fZ025562 for ; Fri, 11 Nov 2016 09:41:07 -0500 Received: from oc8523832656.ibm.com (icon-9-164-178-43.megacenter.de.ibm.com [9.164.178.43]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id uABEf62w025553; Fri, 11 Nov 2016 09:41:06 -0500 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 2E24B108D0B; Fri, 11 Nov 2016 15:41:05 +0100 (CET) Subject: Re: [PATCH] Don't handle unavailable/optimized-out in spu_software_single_step To: qiyaoltc@gmail.com (Yao Qi) Date: Fri, 11 Nov 2016 14:41:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1478873776-16689-1-git-send-email-yao.qi@linaro.org> from "Yao Qi" at Nov 11, 2016 02:16:16 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16111114-0020-0000-0000-0000022CBDF8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16111114-0021-0000-0000-00001E459E78 Message-Id: <20161111144105.2E24B108D0B@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-11_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=1 spamscore=1 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611110262 X-SW-Source: 2016-11/txt/msg00292.txt.bz2 Yao Qi wrote: > When we do software single step, frame is always the innermost one, > so it is impossible to get unavailable/optimized-out errors. > > gdb: > > 2016-11-11 Yao Qi > > * spu-tdep.c (spu_software_single_step): Don't call > get_frame_register_bytes, call get_frame_register_unsigned > instead. Looks good to me. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com