From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: gdb-patches@sourceware.org, palves@redhat.com
Cc: "Marcin Kościelnicki" <koriakin@0x04.net>
Subject: [PATCH] gdb/reverse: Fix continue_to_breakpoint in syscall testcases.
Date: Mon, 02 Nov 2015 18:53:00 -0000 [thread overview]
Message-ID: <1446490031-3226-1-git-send-email-koriakin@0x04.net> (raw)
In-Reply-To: <563791E6.9010200@redhat.com>
continue_to_breakpoint always continues to the next breakpoint, not to the
one named in parameter. This rendered the tests effectively useless, since
marker2 was never reached.
gdb/testsuite/ChangeLog:
* gdb.reverse/fstatat-reverse.exp: Fix continue_to_breakpoint.
* gdb.reverse/getresuid-reverse.exp: Fix continue_to_breakpoint.
* gdb.reverse/pipe-reverse.exp: Fix continue_to_breakpoint.
* gdb.reverse/readv-reverse.exp: Fix continue_to_breakpoint and comment.
* gdb.reverse/recvmsg-reverse.exp: Fix continue_to_breakpoint.
* gdb.reverse/time-reverse.exp: Fix continue_to_breakpoint.
* gdb.reverse/waitpid-reverse.exp: Fix continue_to_breakpoint, add KFAILs.
---
Here comes the fix.
gdb/testsuite/ChangeLog | 10 ++++++++++
gdb/testsuite/gdb.reverse/fstatat-reverse.exp | 2 ++
gdb/testsuite/gdb.reverse/getresuid-reverse.exp | 2 ++
gdb/testsuite/gdb.reverse/pipe-reverse.exp | 2 ++
gdb/testsuite/gdb.reverse/readv-reverse.exp | 4 +++-
gdb/testsuite/gdb.reverse/recvmsg-reverse.exp | 2 ++
gdb/testsuite/gdb.reverse/time-reverse.exp | 2 ++
gdb/testsuite/gdb.reverse/waitpid-reverse.exp | 4 ++++
8 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index e01ee86..4ba75dc 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,13 @@
+2015-11-02 Marcin KoÅcielnicki <koriakin@0x04.net>
+
+ * gdb.reverse/fstatat-reverse.exp: Fix continue_to_breakpoint.
+ * gdb.reverse/getresuid-reverse.exp: Fix continue_to_breakpoint.
+ * gdb.reverse/pipe-reverse.exp: Fix continue_to_breakpoint.
+ * gdb.reverse/readv-reverse.exp: Fix continue_to_breakpoint and comment.
+ * gdb.reverse/recvmsg-reverse.exp: Fix continue_to_breakpoint.
+ * gdb.reverse/time-reverse.exp: Fix continue_to_breakpoint.
+ * gdb.reverse/waitpid-reverse.exp: Fix continue_to_breakpoint, add KFAILs.
+
2015-10-30 Yao Qi <yao.qi@linaro.org>
* gdb.threads/wp-replication.c (watch_count_done): Remove.
diff --git a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp
index 09deb6c..39401dc 100644
--- a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp
@@ -44,6 +44,8 @@ gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
+gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*"
+
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
diff --git a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp
index b93fb91..787457c 100644
--- a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp
@@ -44,6 +44,8 @@ gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
+gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*"
+
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
diff --git a/gdb/testsuite/gdb.reverse/pipe-reverse.exp b/gdb/testsuite/gdb.reverse/pipe-reverse.exp
index 482893a..d298a35 100644
--- a/gdb/testsuite/gdb.reverse/pipe-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/pipe-reverse.exp
@@ -44,6 +44,8 @@ gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
+gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*"
+
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
diff --git a/gdb/testsuite/gdb.reverse/readv-reverse.exp b/gdb/testsuite/gdb.reverse/readv-reverse.exp
index 4158c10..a98ded5 100644
--- a/gdb/testsuite/gdb.reverse/readv-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/readv-reverse.exp
@@ -16,7 +16,7 @@
# This file is part of the gdb testsuite.
#
-# This test tests pipe syscall for reverse execution.
+# This test tests readv syscall for reverse execution.
#
if ![supports_reverse] {
@@ -44,6 +44,8 @@ gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
+gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*"
+
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
diff --git a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp
index 7293a3d..1cb44d3 100644
--- a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp
@@ -44,6 +44,8 @@ gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
+gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*"
+
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
diff --git a/gdb/testsuite/gdb.reverse/time-reverse.exp b/gdb/testsuite/gdb.reverse/time-reverse.exp
index 9cec3c3..5b3d9a3 100644
--- a/gdb/testsuite/gdb.reverse/time-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/time-reverse.exp
@@ -44,6 +44,8 @@ gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
+gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*"
+
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
diff --git a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp
index f4a4403..27d84a1 100644
--- a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp
@@ -44,8 +44,12 @@ gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
+gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*"
+
+setup_kfail "gdb/19187" *-*-*
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
+setup_kfail "gdb/19187" *-*-*
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
# If the variable was recorded properly on syscall, the old contents (-1)
--
2.6.2
next prev parent reply other threads:[~2015-11-02 18:53 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 21:41 gdb/linux-record fixes Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 08/11] gdb/linux-record: Fix newfstatat handling Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 06/11] gdb/linux-record: Support time, waitpid, pipe syscalls Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 03/11] gdb/linux-record: Fix sizes of sigaction and sigset_t Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 09/11] gdb/linux-record: Fix old_select syscall handling Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 04/11] gdb/linux-record: Fix readdir and getdents handling Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 01/11] gdb/linux-record: Remove size_siginfo Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 07/11] gdb/linux-record: Fix [sg]etgroups16 syscall Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 11/11] gdb/linux-record: Fix struct sizes for x32 + aarch64 Marcin Kościelnicki
2015-10-17 21:49 ` [PATCH 02/11] gdb/linux-record: Fix size_[ug]id values Marcin Kościelnicki
2015-10-17 21:49 ` [PATCH 10/11] gdb/linux-record: TASK_COMM_LEN is 16 on ppc too Marcin Kościelnicki
2015-10-17 21:49 ` [PATCH 05/11] gdb/linux-record: Fix msghdr parsing on 64-bit targets Marcin Kościelnicki
2015-10-19 15:37 ` gdb/linux-record fixes Pedro Alves
2015-10-19 17:18 ` Marcin Kościelnicki
2015-10-20 11:07 ` Pedro Alves
2015-10-20 11:16 ` Marcin Kościelnicki
2015-10-22 13:39 ` Marcin Kościelnicki
2015-10-22 13:39 ` [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls Marcin Kościelnicki
2015-10-22 13:43 ` [PATCH v2 11/13] gdb/linux-record: TASK_COMM_LEN is 16 on ppc too Marcin Kościelnicki
2015-10-22 13:45 ` [PATCH v2 12/13] gdb/linux-record: Fix size_termios for x32, amd64, aarch64 Marcin Kościelnicki
2015-10-22 13:45 ` [PATCH v2 13/13] gdb/linux-record: Fix struct sizes for x32 Marcin Kościelnicki
2015-10-22 13:45 ` [PATCH v2 03/13] gdb/linux-record: Fix size_[ug]id values Marcin Kościelnicki
2015-10-22 13:49 ` [PATCH v2 10/13] gdb/linux-record: Fix old_select syscall handling Marcin Kościelnicki
2015-10-22 13:51 ` [PATCH v2 06/13] gdb/linux-record: Fix msghdr parsing on 64-bit targets Marcin Kościelnicki
2015-10-22 13:51 ` [PATCH v2 04/13] gdb/linux-record: Fix sizes of sigaction and sigset_t Marcin Kościelnicki
2015-10-22 13:55 ` [PATCH v2 07/13] gdb/linux-record: Support time, waitpid, pipe syscalls Marcin Kościelnicki
2015-10-22 14:32 ` [PATCH v2 02/13] gdb/linux-record: Remove size_siginfo Marcin Kościelnicki
2015-10-22 15:01 ` [PATCH v2 08/13] gdb/linux-record: Fix [gs]etgroups16 syscall Marcin Kościelnicki
2015-10-22 15:06 ` [PATCH v2 05/13] gdb/linux-record: Fix readdir and getdents handling Marcin Kościelnicki
2015-10-22 15:07 ` [PATCH v2 09/13] gdb/linux-record: Fix newfstatat handling Marcin Kościelnicki
2015-10-29 13:03 ` [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls Pedro Alves
2015-10-29 13:03 ` Marcin Kościelnicki
2015-10-30 14:52 ` Pedro Alves
2015-10-30 10:36 ` Marcin Kościelnicki
2015-10-30 15:05 ` Pedro Alves
2015-11-02 1:34 ` Marcin Kościelnicki
2015-11-02 16:40 ` Pedro Alves
2015-11-02 18:53 ` Marcin Kościelnicki [this message]
2015-11-02 19:17 ` [PATCH] gdb/reverse: Fix continue_to_breakpoint in syscall testcases Pedro Alves
2015-11-02 19:58 ` [PATCH 1/2] " Marcin Kościelnicki
2015-11-02 19:58 ` [PATCH 1/2] Obvious typo fix in gdb.reverse/readv-reverse.exp Marcin Kościelnicki
2015-11-02 20:00 ` Pedro Alves
2015-11-02 19:59 ` [PATCH 1/2] gdb/reverse: Fix continue_to_breakpoint in syscall testcases Pedro Alves
2015-10-30 10:37 ` [PATCH 01/13] gdb/record: Add testcases for a few syscalls Marcin Kościelnicki
2015-10-30 15:41 ` Pedro Alves
2015-10-30 15:55 ` [PATCH v4 " Marcin Kościelnicki
2015-10-31 18:59 ` Pedro Alves
2015-10-29 13:03 ` gdb/linux-record fixes Pedro Alves
2015-10-29 13:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446490031-3226-1-git-send-email-koriakin@0x04.net \
--to=koriakin@0x04.net \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox