From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105856 invoked by alias); 2 Nov 2015 18:53:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105826 invoked by uid 89); 2 Nov 2015 18:53:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Nov 2015 18:53:41 +0000 Received: from hogfather.0x04.net (89-65-84-110.dynamic.chello.pl [89.65.84.110]) by xyzzy.0x04.net (Postfix) with ESMTPS id 07259400E4; Mon, 2 Nov 2015 19:53:57 +0100 (CET) Received: by hogfather.0x04.net (Postfix, from userid 1000) id 655075800D4; Mon, 2 Nov 2015 19:47:17 +0100 (CET) From: =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= To: gdb-patches@sourceware.org, palves@redhat.com Cc: =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= Subject: [PATCH] gdb/reverse: Fix continue_to_breakpoint in syscall testcases. Date: Mon, 02 Nov 2015 18:53:00 -0000 Message-Id: <1446490031-3226-1-git-send-email-koriakin@0x04.net> In-Reply-To: <563791E6.9010200@redhat.com> References: <563791E6.9010200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-11/txt/msg00022.txt.bz2 continue_to_breakpoint always continues to the next breakpoint, not to the one named in parameter. This rendered the tests effectively useless, since marker2 was never reached. gdb/testsuite/ChangeLog: * gdb.reverse/fstatat-reverse.exp: Fix continue_to_breakpoint. * gdb.reverse/getresuid-reverse.exp: Fix continue_to_breakpoint. * gdb.reverse/pipe-reverse.exp: Fix continue_to_breakpoint. * gdb.reverse/readv-reverse.exp: Fix continue_to_breakpoint and comment. * gdb.reverse/recvmsg-reverse.exp: Fix continue_to_breakpoint. * gdb.reverse/time-reverse.exp: Fix continue_to_breakpoint. * gdb.reverse/waitpid-reverse.exp: Fix continue_to_breakpoint, add KFAILs. --- Here comes the fix. gdb/testsuite/ChangeLog | 10 ++++++++++ gdb/testsuite/gdb.reverse/fstatat-reverse.exp | 2 ++ gdb/testsuite/gdb.reverse/getresuid-reverse.exp | 2 ++ gdb/testsuite/gdb.reverse/pipe-reverse.exp | 2 ++ gdb/testsuite/gdb.reverse/readv-reverse.exp | 4 +++- gdb/testsuite/gdb.reverse/recvmsg-reverse.exp | 2 ++ gdb/testsuite/gdb.reverse/time-reverse.exp | 2 ++ gdb/testsuite/gdb.reverse/waitpid-reverse.exp | 4 ++++ 8 files changed, 27 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index e01ee86..4ba75dc 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,13 @@ +2015-11-02 Marcin Kościelnicki + + * gdb.reverse/fstatat-reverse.exp: Fix continue_to_breakpoint. + * gdb.reverse/getresuid-reverse.exp: Fix continue_to_breakpoint. + * gdb.reverse/pipe-reverse.exp: Fix continue_to_breakpoint. + * gdb.reverse/readv-reverse.exp: Fix continue_to_breakpoint and comment. + * gdb.reverse/recvmsg-reverse.exp: Fix continue_to_breakpoint. + * gdb.reverse/time-reverse.exp: Fix continue_to_breakpoint. + * gdb.reverse/waitpid-reverse.exp: Fix continue_to_breakpoint, add KFAILs. + 2015-10-30 Yao Qi * gdb.threads/wp-replication.c (watch_count_done): Remove. diff --git a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp index 09deb6c..39401dc 100644 --- a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp +++ b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp @@ -44,6 +44,8 @@ gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" + gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" diff --git a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp index b93fb91..787457c 100644 --- a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp @@ -44,6 +44,8 @@ gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" + gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" diff --git a/gdb/testsuite/gdb.reverse/pipe-reverse.exp b/gdb/testsuite/gdb.reverse/pipe-reverse.exp index 482893a..d298a35 100644 --- a/gdb/testsuite/gdb.reverse/pipe-reverse.exp +++ b/gdb/testsuite/gdb.reverse/pipe-reverse.exp @@ -44,6 +44,8 @@ gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" + gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" diff --git a/gdb/testsuite/gdb.reverse/readv-reverse.exp b/gdb/testsuite/gdb.reverse/readv-reverse.exp index 4158c10..a98ded5 100644 --- a/gdb/testsuite/gdb.reverse/readv-reverse.exp +++ b/gdb/testsuite/gdb.reverse/readv-reverse.exp @@ -16,7 +16,7 @@ # This file is part of the gdb testsuite. # -# This test tests pipe syscall for reverse execution. +# This test tests readv syscall for reverse execution. # if ![supports_reverse] { @@ -44,6 +44,8 @@ gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" + gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" diff --git a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp index 7293a3d..1cb44d3 100644 --- a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp +++ b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp @@ -44,6 +44,8 @@ gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" + gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" diff --git a/gdb/testsuite/gdb.reverse/time-reverse.exp b/gdb/testsuite/gdb.reverse/time-reverse.exp index 9cec3c3..5b3d9a3 100644 --- a/gdb/testsuite/gdb.reverse/time-reverse.exp +++ b/gdb/testsuite/gdb.reverse/time-reverse.exp @@ -44,6 +44,8 @@ gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" + gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" diff --git a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp index f4a4403..27d84a1 100644 --- a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp @@ -44,8 +44,12 @@ gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" + +setup_kfail "gdb/19187" *-*-* gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +setup_kfail "gdb/19187" *-*-* gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variable was recorded properly on syscall, the old contents (-1) -- 2.6.2