From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: palves@redhat.com, qiyaoltc@gmail.com
Cc: gdb-patches@sourceware.org, "Marcin Kościelnicki" <koriakin@0x04.net>
Subject: [PATCH v2 08/13] gdb/linux-record: Fix [gs]etgroups16 syscall
Date: Thu, 22 Oct 2015 15:01:00 -0000 [thread overview]
Message-ID: <1445521166-14492-8-git-send-email-koriakin@0x04.net> (raw)
In-Reply-To: <1445521166-14492-1-git-send-email-koriakin@0x04.net>
Memory size for getgroups16 needs to be multiplied by entry count, and only
needs recording if the pointer is non-NULL. setgroups16, on the other hand,
doesn't write to user memory and doesn't need special handling at all.
gdb/ChangeLog:
* linux-record.c (record_linux_system_call): Fix [gs]etgroups16.
---
gdb/ChangeLog | 4 ++++
gdb/linux-record.c | 17 ++++++++++-------
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ce717ae..1c3cc04 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2015-10-22 Marcin KoÅcielnicki <koriakin@0x04.net>
+ * linux-record.c (record_linux_system_call): Fix [gs]etgroups16.
+
+2015-10-22 Marcin KoÅcielnicki <koriakin@0x04.net>
+
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Add size_time_t.
* amd64-linux-tdep.c (amd64_linux_init_abi): Add size_time_t.
(amd64_x32_linux_init_abi): Add size_time_t.
diff --git a/gdb/linux-record.c b/gdb/linux-record.c
index dbd8f14..25cbda1 100644
--- a/gdb/linux-record.c
+++ b/gdb/linux-record.c
@@ -628,16 +628,19 @@ record_linux_system_call (enum gdb_syscall syscall,
case gdb_sys_getgroups16:
regcache_raw_read_unsigned (regcache, tdep->arg2, &tmpulongest);
- if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest,
- tdep->size_old_gid_t))
- return -1;
+ if (tmpulongest)
+ {
+ ULONGEST gidsetsize;
+
+ regcache_raw_read_unsigned (regcache, tdep->arg1,
+ &gidsetsize);
+ tmpint = tdep->size_old_gid_t * (int) gidsetsize;
+ if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest, tmpint))
+ return -1;
+ }
break;
case gdb_sys_setgroups16:
- regcache_raw_read_unsigned (regcache, tdep->arg2, &tmpulongest);
- if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest,
- tdep->size_old_gid_t))
- return -1;
break;
case gdb_old_select:
--
2.6.1
next prev parent reply other threads:[~2015-10-22 13:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 21:41 gdb/linux-record fixes Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 11/11] gdb/linux-record: Fix struct sizes for x32 + aarch64 Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 07/11] gdb/linux-record: Fix [sg]etgroups16 syscall Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 04/11] gdb/linux-record: Fix readdir and getdents handling Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 01/11] gdb/linux-record: Remove size_siginfo Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 09/11] gdb/linux-record: Fix old_select syscall handling Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 06/11] gdb/linux-record: Support time, waitpid, pipe syscalls Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 03/11] gdb/linux-record: Fix sizes of sigaction and sigset_t Marcin Kościelnicki
2015-10-17 21:41 ` [PATCH 08/11] gdb/linux-record: Fix newfstatat handling Marcin Kościelnicki
2015-10-17 21:49 ` [PATCH 05/11] gdb/linux-record: Fix msghdr parsing on 64-bit targets Marcin Kościelnicki
2015-10-17 21:49 ` [PATCH 10/11] gdb/linux-record: TASK_COMM_LEN is 16 on ppc too Marcin Kościelnicki
2015-10-17 21:49 ` [PATCH 02/11] gdb/linux-record: Fix size_[ug]id values Marcin Kościelnicki
2015-10-19 15:37 ` gdb/linux-record fixes Pedro Alves
2015-10-19 17:18 ` Marcin Kościelnicki
2015-10-20 11:07 ` Pedro Alves
2015-10-20 11:16 ` Marcin Kościelnicki
2015-10-22 13:39 ` Marcin Kościelnicki
2015-10-22 13:39 ` [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls Marcin Kościelnicki
2015-10-22 13:43 ` [PATCH v2 11/13] gdb/linux-record: TASK_COMM_LEN is 16 on ppc too Marcin Kościelnicki
2015-10-22 13:45 ` [PATCH v2 12/13] gdb/linux-record: Fix size_termios for x32, amd64, aarch64 Marcin Kościelnicki
2015-10-22 13:45 ` [PATCH v2 03/13] gdb/linux-record: Fix size_[ug]id values Marcin Kościelnicki
2015-10-22 13:45 ` [PATCH v2 13/13] gdb/linux-record: Fix struct sizes for x32 Marcin Kościelnicki
2015-10-22 13:49 ` [PATCH v2 10/13] gdb/linux-record: Fix old_select syscall handling Marcin Kościelnicki
2015-10-22 13:51 ` [PATCH v2 06/13] gdb/linux-record: Fix msghdr parsing on 64-bit targets Marcin Kościelnicki
2015-10-22 13:51 ` [PATCH v2 04/13] gdb/linux-record: Fix sizes of sigaction and sigset_t Marcin Kościelnicki
2015-10-22 13:55 ` [PATCH v2 07/13] gdb/linux-record: Support time, waitpid, pipe syscalls Marcin Kościelnicki
2015-10-22 14:32 ` [PATCH v2 02/13] gdb/linux-record: Remove size_siginfo Marcin Kościelnicki
2015-10-22 15:01 ` Marcin Kościelnicki [this message]
2015-10-22 15:06 ` [PATCH v2 05/13] gdb/linux-record: Fix readdir and getdents handling Marcin Kościelnicki
2015-10-22 15:07 ` [PATCH v2 09/13] gdb/linux-record: Fix newfstatat handling Marcin Kościelnicki
2015-10-29 13:03 ` [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls Pedro Alves
2015-10-29 13:03 ` Marcin Kościelnicki
2015-10-30 14:52 ` Pedro Alves
2015-10-30 10:36 ` Marcin Kościelnicki
2015-10-30 15:05 ` Pedro Alves
2015-11-02 1:34 ` Marcin Kościelnicki
2015-11-02 16:40 ` Pedro Alves
2015-11-02 18:53 ` [PATCH] gdb/reverse: Fix continue_to_breakpoint in syscall testcases Marcin Kościelnicki
2015-11-02 19:17 ` Pedro Alves
2015-11-02 19:58 ` [PATCH 1/2] " Marcin Kościelnicki
2015-11-02 19:58 ` [PATCH 1/2] Obvious typo fix in gdb.reverse/readv-reverse.exp Marcin Kościelnicki
2015-11-02 20:00 ` Pedro Alves
2015-11-02 19:59 ` [PATCH 1/2] gdb/reverse: Fix continue_to_breakpoint in syscall testcases Pedro Alves
2015-10-30 10:37 ` [PATCH 01/13] gdb/record: Add testcases for a few syscalls Marcin Kościelnicki
2015-10-30 15:41 ` Pedro Alves
2015-10-30 15:55 ` [PATCH v4 " Marcin Kościelnicki
2015-10-31 18:59 ` Pedro Alves
2015-10-29 13:03 ` gdb/linux-record fixes Pedro Alves
2015-10-29 13:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445521166-14492-8-git-send-email-koriakin@0x04.net \
--to=koriakin@0x04.net \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox