[committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[KARTHIKVENKATESH BHAT]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 1604 bytes --]

Thanks for the review. Committed after formatting.

------- Original Message -------
Sender : Joel Brobecker<brobecker@adacore.com>
Date : Sep 26, 2012 00:49 (GMT+09:00)
Title : Re: [PATCH] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

Karthik,

Thanks for the fix.

> +2012-09-25  Karthik Bhat  
> + 
> + * alpha-tdep.c (arm_skip_prologue): Extending support for LLVM compiler. 
Wrong filename. The patch looks good and is OK to commit provided
you fix the formatting issue outlined below.

Do you have a copyright assignment on file? This patch is small enough
that it can be accepted without one, but if you are planing on
contributing more changes, having one would become necessary.
Let me know if you need to get started on the paperwork.

> Index: gdb/arm-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> retrieving revision 1.367
> diff -u -p -r1.367 arm-tdep.c
> --- gdb/arm-tdep.c 22 Aug 2012 19:47:56 -0000 1.367
> +++ gdb/arm-tdep.c 25 Sep 2012 13:34:54 -0000
> @@ -1400,7 +1400,7 @@ arm_skip_prologue (struct gdbarch *gdbar
>        if (post_prologue_pc
>     && (s == NULL
>         || s->producer == NULL
> -       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0))
> +       || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0 || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0))

Please move the addition || condition on the next line, properly aligned
with the others.

-- 
Joel\x16º&Öéj×!zÊÞ¶êç÷:ÒX¬µªÜ†\a[¥«\…ë

Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[Yao Qi]

On 09/26/2012 08:23 PM, KARTHIKVENKATESH BHAT wrote:
> Thanks for the review. Committed after formatting.

The changelog entry is too long, usually it should not exceed 70
characters, and there is a trailing space.  I fixed it in the
patch below.

Your patch fixes a PR, so you should add the PR number into your
changelog entry, so that bugzilla can link this commit to the PR, like
this,


2012-09-26  Karthik Bhat  <kv.bhat@samsung.com>

	PR breakpoints/14419
	* arm-tdep.c (arm_skip_prologue): XXXX
-- 
Yao

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14700
diff -u -r1.14700 ChangeLog
--- ChangeLog	26 Sep 2012 12:14:30 -0000	1.14700
+++ ChangeLog	26 Sep 2012 13:36:17 -0000
@@ -1,6 +1,7 @@
 2012-09-26  Karthik Bhat  <kv.bhat@samsung.com>
 
-	* arm-tdep.c (arm_skip_prologue): Extending producer check to support LLVM compiler. 
+	* arm-tdep.c (arm_skip_prologue): Extending producer check to
+	support LLVM compiler.
 
 2012-09-26  Siddhesh Poyarekar  <siddhesh@redhat.com>
 

Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419)

[Yao Qi]

On 09/26/2012 10:19 PM, KARTHIKVENKATESH BHAT wrote:
> Thanks. I have added PR number to Changelog as mentioned.

Sorry, the PR number is added in a wrong way.  The blank line is missing 
between your name and PR number.

2012-09-26  Karthik Bhat  <kv.bhat@samsung.com>
//<-- here
	PR breakpoints/14419
	* arm-tdep.c (arm_skip_prologue): Extending producer check to
	support LLVM compiler.

-- 
Yao