From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27924 invoked by alias); 26 Sep 2012 13:45:27 -0000 Received: (qmail 27913 invoked by uid 22791); 26 Sep 2012 13:45:25 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 13:45:12 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TGrvI-0000uv-5S from Yao_Qi@mentor.com ; Wed, 26 Sep 2012 06:45:08 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 26 Sep 2012 06:45:08 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Wed, 26 Sep 2012 06:45:06 -0700 Message-ID: <506306DE.3070603@codesourcery.com> Date: Wed, 26 Sep 2012 13:45:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: CC: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [committed] Prologue not set properly for binaries compiled with LLVM compiler (Bug #14419) References: <1435799.298501348662204287.JavaMail.weblogic@epml01> In-Reply-To: <1435799.298501348662204287.JavaMail.weblogic@epml01> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00584.txt.bz2 On 09/26/2012 08:23 PM, KARTHIKVENKATESH BHAT wrote: > Thanks for the review. Committed after formatting. The changelog entry is too long, usually it should not exceed 70 characters, and there is a trailing space. I fixed it in the patch below. Your patch fixes a PR, so you should add the PR number into your changelog entry, so that bugzilla can link this commit to the PR, like this, 2012-09-26 Karthik Bhat PR breakpoints/14419 * arm-tdep.c (arm_skip_prologue): XXXX -- Yao Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.14700 diff -u -r1.14700 ChangeLog --- ChangeLog 26 Sep 2012 12:14:30 -0000 1.14700 +++ ChangeLog 26 Sep 2012 13:36:17 -0000 @@ -1,6 +1,7 @@ 2012-09-26 Karthik Bhat - * arm-tdep.c (arm_skip_prologue): Extending producer check to support LLVM compiler. + * arm-tdep.c (arm_skip_prologue): Extending producer check to + support LLVM compiler. 2012-09-26 Siddhesh Poyarekar