Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Implement ${board}_{exec,spawn} for native-extended-gdbserver
@ 2015-02-03 23:21 Sergio Durigan Junior
  2015-02-04 13:06 ` Pedro Alves
  0 siblings, 1 reply; 4+ messages in thread
From: Sergio Durigan Junior @ 2015-02-03 23:21 UTC (permalink / raw)
  To: GDB Patches; +Cc: Pedro Alves, Mark Wielaard, Sergio Durigan Junior

Hi,

Mark Wielaard is kindly running two Debian buildslaves in our
buildbot, and he noticed that, when testing things under the
native-extended-gdbserver board, there is a huge slowndown due to
several timeouts that are happening.

If you look at the following log:

  <http://gdb-build.sergiodj.net/builders/Debian-i686-native-extended-gdbserver/builds/48/steps/test%20gdb/logs/stdio>

You will notice that this happens because dejagnu is trying to open a
rsh connection to test native-extended-gdbserver, which of course is
wrong, and we end up not testing things properly.

After some investigation (motivated by an idea from Pedro), I found
that our native-extended-gdbserver board does not set the "isremote"
flag properly.  I fixed that by doing two things:

- Defining the ${board}_spawn procedure inside the board file, and

- Moving the ${board}_exec procedure (present at the native-gdbserver
  and native-stdio-gdbserver boards) to the gdbserver-base file.

After that, I am not seeing this failure anymore.

Is this OK to check in?

gdb/testsuite/ChangeLog:
2015-02-03  Sergio Durigan Junior  <sergiodj@redhat.com>

	* boards/gdbserver-base.exp (${board}_exec): New procedure, moved
	from native-gdbserver.exp and native-stdio-gdbserver.exp.
	* boards/native-extended-gdbserver.exp: Do not set isremote using
	board_info.
	(${board}_spawn): New procedure.
	* boards/native-gdbserver.exp (${board}_exec): Moved to
	gdbserver-base.exp.
	* boards/native-stdio-gdbserver.exp (${board}_exec): Likewise.
---
 gdb/testsuite/boards/gdbserver-base.exp            | 12 ++++++++++++
 gdb/testsuite/boards/native-extended-gdbserver.exp | 18 ++++++++++++------
 gdb/testsuite/boards/native-gdbserver.exp          | 12 ------------
 gdb/testsuite/boards/native-stdio-gdbserver.exp    | 12 ------------
 4 files changed, 24 insertions(+), 30 deletions(-)

diff --git a/gdb/testsuite/boards/gdbserver-base.exp b/gdb/testsuite/boards/gdbserver-base.exp
index c77dc6e..1a52915 100644
--- a/gdb/testsuite/boards/gdbserver-base.exp
+++ b/gdb/testsuite/boards/gdbserver-base.exp
@@ -50,3 +50,15 @@ proc ${board}_download { board host dest } {
 proc ${board}_upload {dest srcfile args} {
     return $srcfile
 }
+
+proc ${board}_exec { hostname program args } {
+    global board_info
+
+    set baseboard [lindex [split $hostname "/"] 0]
+
+    set board_info($baseboard,isremote) 0
+    set result [remote_exec $hostname $program $args]
+    set board_info($baseboard,isremote) 1
+
+    return $result
+}
diff --git a/gdb/testsuite/boards/native-extended-gdbserver.exp b/gdb/testsuite/boards/native-extended-gdbserver.exp
index 57503db..0059c4e 100644
--- a/gdb/testsuite/boards/native-extended-gdbserver.exp
+++ b/gdb/testsuite/boards/native-extended-gdbserver.exp
@@ -23,12 +23,6 @@
 load_generic_config "extended-gdbserver"
 load_board_description "gdbserver-base"
 
-# By default, dejagnu makes the board remote unless the board name
-# matches localhost.  Force it to be NOT remote.
-global board
-global board_info
-set board_info($board,isremote) 0
-
 set_board_info sockethost "localhost:"
 
 # We will be using the extended GDB remote protocol.
@@ -119,3 +113,15 @@ proc mi_gdb_load { arg } {
 
     return 0
 }
+
+proc ${board}_spawn { board cmd } {
+    global board_info
+
+    set baseboard [lindex [split $board "/"] 0]
+
+    set board_info($baseboard,isremote) 0
+    set result [remote_spawn $board $cmd]
+    set board_info($baseboard,isremote) 1
+
+    return $result
+}
diff --git a/gdb/testsuite/boards/native-gdbserver.exp b/gdb/testsuite/boards/native-gdbserver.exp
index 7738b2e..3d972ba 100644
--- a/gdb/testsuite/boards/native-gdbserver.exp
+++ b/gdb/testsuite/boards/native-gdbserver.exp
@@ -47,15 +47,3 @@ proc ${board}_spawn { board cmd } {
 
     return $result
 }
-
-proc ${board}_exec { hostname program args } {
-    global board_info
-
-    set baseboard [lindex [split $hostname "/"] 0]
-
-    set board_info($baseboard,isremote) 0
-    set result [remote_exec $hostname $program $args]
-    set board_info($baseboard,isremote) 1
-
-    return $result
-}
diff --git a/gdb/testsuite/boards/native-stdio-gdbserver.exp b/gdb/testsuite/boards/native-stdio-gdbserver.exp
index 2ec2a47..b8d0949 100644
--- a/gdb/testsuite/boards/native-stdio-gdbserver.exp
+++ b/gdb/testsuite/boards/native-stdio-gdbserver.exp
@@ -75,15 +75,3 @@ proc ${board}_spawn { board cmd } {
 
     return $result
 }
-
-proc ${board}_exec { hostname program args } {
-    global board_info
-
-    set baseboard [lindex [split $hostname "/"] 0]
-
-    set board_info($baseboard,isremote) 0
-    set result [remote_exec $hostname $program $args]
-    set board_info($baseboard,isremote) 1
-
-    return $result
-}
-- 
1.9.3


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-06  8:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-03 23:21 [PATCH] Implement ${board}_{exec,spawn} for native-extended-gdbserver Sergio Durigan Junior
2015-02-04 13:06 ` Pedro Alves
2015-02-04 13:59   ` Pedro Alves
2015-02-06  8:45   ` Doug Evans

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox