From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21929 invoked by alias); 4 Feb 2015 13:06:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21919 invoked by uid 89); 4 Feb 2015 13:06:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Feb 2015 13:06:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t14D5us0024230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Feb 2015 08:05:56 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t14D5rtJ008521; Wed, 4 Feb 2015 08:05:55 -0500 Message-ID: <54D21931.8040806@redhat.com> Date: Wed, 04 Feb 2015 13:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sergio Durigan Junior , GDB Patches CC: Mark Wielaard Subject: Re: [PATCH] Implement ${board}_{exec,spawn} for native-extended-gdbserver References: <1423005658-31405-1-git-send-email-sergiodj@redhat.com> In-Reply-To: <1423005658-31405-1-git-send-email-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00079.txt.bz2 On 02/04/2015 12:20 AM, Sergio Durigan Junior wrote: > diff --git a/gdb/testsuite/boards/native-extended-gdbserver.exp b/gdb/testsuite/boards/native-extended-gdbserver.exp > index 57503db..0059c4e 100644 > --- a/gdb/testsuite/boards/native-extended-gdbserver.exp > +++ b/gdb/testsuite/boards/native-extended-gdbserver.exp > @@ -23,12 +23,6 @@ > load_generic_config "extended-gdbserver" > load_board_description "gdbserver-base" > > -# By default, dejagnu makes the board remote unless the board name > -# matches localhost. Force it to be NOT remote. > -global board > -global board_info > -set board_info($board,isremote) 0 I don't think we can/should remove this. That'll make "is_remote" checks all over the testsuite return true, and thus skip tests that weren't skipped before. E.g., solib-display.exp. I think we need to instead do here what ${board}_spawn is already doing. That is, remove any target variant specifications from $board, like: --- a/gdb/testsuite/boards/native-extended-gdbserver.exp +++ b/gdb/testsuite/boards/native-extended-gdbserver.exp @@ -27,7 +27,9 @@ load_board_description "gdbserver-base" # matches localhost. Force it to be NOT remote. global board global board_info -set board_info($board,isremote) 0 +# Remove any target variant specifications from the name. +set baseboard [lindex [split $board "/"] 0] +set board_info($baseboard,isremote) 0 I'm testing that. Thanks, Pedro Alves