Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Don't mention "Unix" in native target name.
Date: Wed, 12 Mar 2014 12:38:00 -0000	[thread overview]
Message-ID: <1394627872-18619-1-git-send-email-palves@redhat.com> (raw)

I wonder whether anyone would miss this badly?  The difference would be:

  (gdb) maint print target-stack
  The current target stack is:
   - multi-thread (multi-threaded child process.)
-  - child (Unix child process)
+  - child (Child process)
   - exec (Local exec file)
   - None (None)

 (gdb) help target child
- Unix child process (started by the "run" command).
+ Child process (started by the "run" command).

I find it unnecessary (and really slightly a lie) on GNU/Linux.

It's also odd that e.g., the Windows port says "Unix" in reaction to
"target child" (it was already that way before Windows used
inf-child.c).

How about we just say the same mostly everywhere?

In the same vein, I'd also rename Solaris/procfs.c's "target procfs"
to "target child".

gdb/
2014-03-12  Pedro Alves  <palves@redhat.com>

	* inf-child.c (inf_child_open, inf_child_target): Don't mention
	Unix in user visible strings.
---
 gdb/inf-child.c                    | 6 +++---
 gdb/testsuite/gdb.base/default.exp | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/inf-child.c b/gdb/inf-child.c
index ee63dd1..bfa9152 100644
--- a/gdb/inf-child.c
+++ b/gdb/inf-child.c
@@ -112,7 +112,7 @@ inf_child_prepare_to_store (struct target_ops *self,
 static void
 inf_child_open (char *arg, int from_tty)
 {
-  error (_("Use the \"run\" command to start a Unix child process."));
+  error (_("Use the \"run\" command to start a child process."));
 }
 
 static void
@@ -398,8 +398,8 @@ inf_child_target (void)
   struct target_ops *t = XCNEW (struct target_ops);
 
   t->to_shortname = "child";
-  t->to_longname = "Unix child process";
-  t->to_doc = "Unix child process (started by the \"run\" command).";
+  t->to_longname = "Child process";
+  t->to_doc = "Child process (started by the \"run\" command).";
   t->to_open = inf_child_open;
   t->to_post_attach = inf_child_post_attach;
   t->to_fetch_registers = inf_child_fetch_inferior_registers;
diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp
index 73c33ba..b63955e 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -747,10 +747,10 @@ gdb_test "step" "The program is not being run." "step #2"
 gdb_test "symbol-file" ".*" "symbol-file"
 
 #test target child
-gdb_test "target child" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"child\".  *Try \"help target\".*" "target child"
+gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\".  *Try \"help target\".*" "target child"
 
 #test target procfs
-gdb_test "target procfs" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"procfs\".  *Try \"help target\".*" "target procfs"
+gdb_test "target procfs" "Use the \"run\" command to start a child process.*|Undefined target command: \"procfs\".  *Try \"help target\".*" "target procfs"
 
 #test target core
 send_gdb "target core\n"
-- 
1.7.11.7


             reply	other threads:[~2014-03-12 12:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 12:38 Pedro Alves [this message]
2014-03-12 13:16 ` Gary Benson
2014-03-13  0:13   ` Doug Evans
2014-03-13 12:30     ` Pedro Alves
2014-03-12 13:37 ` Rename Solaris's target to "target child" like most other ports Pedro Alves
2014-03-13  7:39   ` Joel Brobecker
2014-03-13 12:32     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394627872-18619-1-git-send-email-palves@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox