From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22702 invoked by alias); 12 Mar 2014 12:38:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22690 invoked by uid 89); 12 Mar 2014 12:38:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Mar 2014 12:38:01 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2CCbrbm026339 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Mar 2014 08:37:54 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2CCbqje014243 for ; Wed, 12 Mar 2014 08:37:53 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH] Don't mention "Unix" in native target name. Date: Wed, 12 Mar 2014 12:38:00 -0000 Message-Id: <1394627872-18619-1-git-send-email-palves@redhat.com> X-SW-Source: 2014-03/txt/msg00284.txt.bz2 I wonder whether anyone would miss this badly? The difference would be: (gdb) maint print target-stack The current target stack is: - multi-thread (multi-threaded child process.) - - child (Unix child process) + - child (Child process) - exec (Local exec file) - None (None) (gdb) help target child - Unix child process (started by the "run" command). + Child process (started by the "run" command). I find it unnecessary (and really slightly a lie) on GNU/Linux. It's also odd that e.g., the Windows port says "Unix" in reaction to "target child" (it was already that way before Windows used inf-child.c). How about we just say the same mostly everywhere? In the same vein, I'd also rename Solaris/procfs.c's "target procfs" to "target child". gdb/ 2014-03-12 Pedro Alves * inf-child.c (inf_child_open, inf_child_target): Don't mention Unix in user visible strings. --- gdb/inf-child.c | 6 +++--- gdb/testsuite/gdb.base/default.exp | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/inf-child.c b/gdb/inf-child.c index ee63dd1..bfa9152 100644 --- a/gdb/inf-child.c +++ b/gdb/inf-child.c @@ -112,7 +112,7 @@ inf_child_prepare_to_store (struct target_ops *self, static void inf_child_open (char *arg, int from_tty) { - error (_("Use the \"run\" command to start a Unix child process.")); + error (_("Use the \"run\" command to start a child process.")); } static void @@ -398,8 +398,8 @@ inf_child_target (void) struct target_ops *t = XCNEW (struct target_ops); t->to_shortname = "child"; - t->to_longname = "Unix child process"; - t->to_doc = "Unix child process (started by the \"run\" command)."; + t->to_longname = "Child process"; + t->to_doc = "Child process (started by the \"run\" command)."; t->to_open = inf_child_open; t->to_post_attach = inf_child_post_attach; t->to_fetch_registers = inf_child_fetch_inferior_registers; diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index 73c33ba..b63955e 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -747,10 +747,10 @@ gdb_test "step" "The program is not being run." "step #2" gdb_test "symbol-file" ".*" "symbol-file" #test target child -gdb_test "target child" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" +gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" #test target procfs -gdb_test "target procfs" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs" +gdb_test "target procfs" "Use the \"run\" command to start a child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs" #test target core send_gdb "target core\n" -- 1.7.11.7