Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Rename Solaris's target to "target child" like most other ports.
Date: Thu, 13 Mar 2014 07:39:00 -0000	[thread overview]
Message-ID: <20140313073918.GG4882@adacore.com> (raw)
In-Reply-To: <53205797.3050309@redhat.com>

> Like this.  (Untested.)
> 
> -------
> [PATCH] Rename Solaris's target to "target child" like most other
>  ports.
> 
> Note that "target procfs" is used by QNX, but the test must be failing
> there, as nto-procfs.c overrides to_open with a method that doesn't
> throw the error being tested.  So I'm just removing the test
> completely.
> 
> gdb/
> 2014-03-12  Pedro Alves  <palves@redhat.com>
> 
> 	* procfs.c (procfs_target): Don't override to_shortname,
> 	to_longname or to_doc.
> 
> gdb/testsuite/
> 2014-03-12  Pedro Alves  <palves@redhat.com>
> 
> 	* gdb.base/default.exp: Don't test "target procfs".

FWIW, this looks good to commit to me, even if untested. In the very
unlikely even that it does break somethhing, I will take care of it
then.

-- 
Joel


  reply	other threads:[~2014-03-13  7:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 12:38 [PATCH] Don't mention "Unix" in native target name Pedro Alves
2014-03-12 13:16 ` Gary Benson
2014-03-13  0:13   ` Doug Evans
2014-03-13 12:30     ` Pedro Alves
2014-03-12 13:37 ` Rename Solaris's target to "target child" like most other ports Pedro Alves
2014-03-13  7:39   ` Joel Brobecker [this message]
2014-03-13 12:32     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140313073918.GG4882@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox