[PATCH] target: remove return after tcomplain ()

[PATCH] target: remove return after tcomplain ()

[Markus Metzger]

tcomplain does not return.  Remove any redundant return statement following
a call to it.

2014-01-20  Markus Metzger  <markus.t.metzger@intel.com>

	* target.c (dummy_get_bookmark, target_enable_btrace)
	(target_read_btrace): Remove return after tcomplain ().
---
 gdb/target.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gdb/target.c b/gdb/target.c
index 576d6c7..ea9a6d1 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -3760,7 +3760,6 @@ static gdb_byte *
 dummy_get_bookmark (char *ignore1, int ignore2)
 {
   tcomplain ();
-  return NULL;
 }
 
 /* Error-catcher for target_goto_bookmark.  */
@@ -4193,7 +4192,6 @@ target_enable_btrace (ptid_t ptid)
       return t->to_enable_btrace (ptid);
 
   tcomplain ();
-  return NULL;
 }
 
 /* See target.h.  */
@@ -4244,7 +4242,6 @@ target_read_btrace (VEC (btrace_block_s) **btrace,
       return t->to_read_btrace (btrace, btinfo, type);
 
   tcomplain ();
-  return BTRACE_ERR_NOT_SUPPORTED;
 }
 
 /* See target.h.  */
-- 
1.8.3.1

RE: [PATCH] target: remove return after tcomplain ()

[Agovic, Sanimir]

Markus> If this turns out to be unnecessary, I can send a patch to
Markus> remove those extra returns.

Tom> It isn't of major importance.
Tom> If you want to do it, it's fine as an obvious change.

As Tom mentioned you may commit as the "The Obvious Fix Rule" apply (see MAINTAINERS).

 -Sanimir

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Markus Metzger
> Sent: Monday, January 20, 2014 09:59 AM
> To: gdb-patches@sourceware.org
> Subject: [PATCH] target: remove return after tcomplain ()
> 
> tcomplain does not return.  Remove any redundant return statement following
> a call to it.
> 
> 2014-01-20  Markus Metzger  <markus.t.metzger@intel.com>
> 
> 	* target.c (dummy_get_bookmark, target_enable_btrace)
> 	(target_read_btrace): Remove return after tcomplain ().
> ---
>  gdb/target.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/gdb/target.c b/gdb/target.c
> index 576d6c7..ea9a6d1 100644
> --- a/gdb/target.c
> +++ b/gdb/target.c
> @@ -3760,7 +3760,6 @@ static gdb_byte *
>  dummy_get_bookmark (char *ignore1, int ignore2)
>  {
>    tcomplain ();
> -  return NULL;
>  }
> 
>  /* Error-catcher for target_goto_bookmark.  */
> @@ -4193,7 +4192,6 @@ target_enable_btrace (ptid_t ptid)
>        return t->to_enable_btrace (ptid);
> 
>    tcomplain ();
> -  return NULL;
>  }
> 
>  /* See target.h.  */
> @@ -4244,7 +4242,6 @@ target_read_btrace (VEC (btrace_block_s) **btrace,
>        return t->to_read_btrace (btrace, btinfo, type);
> 
>    tcomplain ();
> -  return BTRACE_ERR_NOT_SUPPORTED;
>  }
> 
>  /* See target.h.  */
> --
> 1.8.3.1

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052