From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14956 invoked by alias); 20 Jan 2014 09:26:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14941 invoked by uid 89); 20 Jan 2014 09:26:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Jan 2014 09:26:23 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 20 Jan 2014 01:22:16 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 20 Jan 2014 01:26:20 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 20 Jan 2014 09:26:19 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.215]) by IRSMSX151.ger.corp.intel.com ([169.254.4.126]) with mapi id 14.03.0123.003; Mon, 20 Jan 2014 09:26:19 +0000 From: "Agovic, Sanimir" To: "Metzger, Markus T" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] target: remove return after tcomplain () Date: Mon, 20 Jan 2014 09:26:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176D4BD8@IRSMSX105.ger.corp.intel.com> References: <1390208330-5771-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1390208330-5771-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00738.txt.bz2 Markus> If this turns out to be unnecessary, I can send a patch to Markus> remove those extra returns. Tom> It isn't of major importance. Tom> If you want to do it, it's fine as an obvious change. As Tom mentioned you may commit as the "The Obvious Fix Rule" apply (see MA= INTAINERS). -Sanimir > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf > Of Markus Metzger > Sent: Monday, January 20, 2014 09:59 AM > To: gdb-patches@sourceware.org > Subject: [PATCH] target: remove return after tcomplain () >=20 > tcomplain does not return. Remove any redundant return statement followi= ng > a call to it. >=20 > 2014-01-20 Markus Metzger >=20 > * target.c (dummy_get_bookmark, target_enable_btrace) > (target_read_btrace): Remove return after tcomplain (). > --- > gdb/target.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/gdb/target.c b/gdb/target.c > index 576d6c7..ea9a6d1 100644 > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -3760,7 +3760,6 @@ static gdb_byte * > dummy_get_bookmark (char *ignore1, int ignore2) > { > tcomplain (); > - return NULL; > } >=20 > /* Error-catcher for target_goto_bookmark. */ > @@ -4193,7 +4192,6 @@ target_enable_btrace (ptid_t ptid) > return t->to_enable_btrace (ptid); >=20 > tcomplain (); > - return NULL; > } >=20 > /* See target.h. */ > @@ -4244,7 +4242,6 @@ target_read_btrace (VEC (btrace_block_s) **btrace, > return t->to_read_btrace (btrace, btinfo, type); >=20 > tcomplain (); > - return BTRACE_ERR_NOT_SUPPORTED; > } >=20 > /* See target.h. */ > -- > 1.8.3.1 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052