From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFC-v2] amd64-windows: Fix funcall with by-pointer arguments
Date: Tue, 24 Sep 2013 16:33:00 -0000 [thread overview]
Message-ID: <1380040404-16932-1-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <20130920232017.GU3132@adacore.com>
Hello,
> Once again, I'm short of time to finish what I had hoped to be able
> to complete. But I thought I'd send an update anyway. The first patch
> is an update to the patch I wrote in January, rebased for today's HEAD.
> This is what I have tested and intend to check in soon.
>
> Left to do on my end, is clean things up in amd64-tdep, because many
> hooks in the tdep structure can now be removed, and replaced by
> direct calls. But this is independent of your changes, so we can
> both work at the same time.
I have now checked in the patch re-implementing function call on
amd64-windows. After this was done, I was able to revert all changes
that added hooks in the gdbarch_tdep and in the amd64 sysV code
to tweak it for amd64-windows, since the two implementations are
now completely distinct.
All patches were tested on x86_64-linux and x86_64-windows.
And just in case, I tested them on x86-windows as well.
Thanks,
--
Joel
next prev parent reply other threads:[~2013-09-24 16:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 17:23 Joel Brobecker
2012-10-24 17:23 ` [RFA 2/2] amd64-windows: Arguments passed by pointer Joel Brobecker
2012-10-24 17:24 ` [RFA 1/2] Revert "amd64-windows: memory args passed by pointer during function calls." Joel Brobecker
2012-10-25 13:18 ` amd64-windows: Fix funcall with by-pointer arguments Mark Kettenis
2013-01-16 11:59 ` Joel Brobecker
2013-09-13 22:11 ` [RFC-v2] " Pierre Muller
2013-09-16 20:57 ` Joel Brobecker
2013-09-17 13:50 ` Joel Brobecker
2013-09-20 23:20 ` Joel Brobecker
2013-09-24 16:33 ` Joel Brobecker [this message]
2013-09-24 16:33 ` [commit 2/4] Revert use of integer_param_regs_saved_in_caller_frame in i386 gdbarch_tdep Joel Brobecker
2013-09-24 16:33 ` [commit 3/4] Revert use of memory_args_by_pointer " Joel Brobecker
2013-09-24 16:33 ` [commit 4/4] Revert use of classify callback " Joel Brobecker
2013-09-24 16:33 ` [commit 1/4] Reimplement function calls on amd64-windows Joel Brobecker
2013-09-24 17:26 ` fixed ChangeLog: " Joel Brobecker
2013-09-24 16:53 ` [RFC-v2] amd64-windows: Fix funcall with by-pointer arguments Mark Kettenis
2013-09-24 22:02 ` Pierre Muller
2013-09-26 0:34 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380040404-16932-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox