From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6709 invoked by alias); 24 Sep 2013 16:33:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6692 invoked by uid 89); 24 Sep 2013 16:33:31 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 24 Sep 2013 16:33:31 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3977E11670D; Tue, 24 Sep 2013 12:33:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5sOloMVDdD6J; Tue, 24 Sep 2013 12:33:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C684611670B; Tue, 24 Sep 2013 12:33:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 49256E0314; Tue, 24 Sep 2013 09:33:27 -0700 (PDT) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: Pierre Muller , Mark Kettenis Subject: Re: [RFC-v2] amd64-windows: Fix funcall with by-pointer arguments Date: Tue, 24 Sep 2013 16:33:00 -0000 Message-Id: <1380040404-16932-1-git-send-email-brobecker@adacore.com> In-Reply-To: <20130920232017.GU3132@adacore.com> References: <20130920232017.GU3132@adacore.com> X-SW-Source: 2013-09/txt/msg00866.txt.bz2 Hello, > Once again, I'm short of time to finish what I had hoped to be able > to complete. But I thought I'd send an update anyway. The first patch > is an update to the patch I wrote in January, rebased for today's HEAD. > This is what I have tested and intend to check in soon. > > Left to do on my end, is clean things up in amd64-tdep, because many > hooks in the tdep structure can now be removed, and replaced by > direct calls. But this is independent of your changes, so we can > both work at the same time. I have now checked in the patch re-implementing function call on amd64-windows. After this was done, I was able to revert all changes that added hooks in the gdbarch_tdep and in the amd64 sysV code to tweak it for amd64-windows, since the two implementations are now completely distinct. All patches were tested on x86_64-linux and x86_64-windows. And just in case, I tested them on x86-windows as well. Thanks, -- Joel