From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: amd64-windows: Fix funcall with by-pointer arguments
Date: Thu, 25 Oct 2012 13:18:00 -0000 [thread overview]
Message-ID: <201210251317.q9PDHrnJ026193@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1351099417-18960-1-git-send-email-brobecker@adacore.com>
> From: "Joel Brobecker" <brobecker@adacore.com>
> Date: Wed, 24 Oct 2012 13:23:35 -0400
>
> Hello,
>
> I realized a while ago that I completely misunderstood the amd64-windows
> API regarding arguments that are passed by pointer. The calling
> convention is published there:
>
> http://msdn.microsoft.com/en-us/library/zthk2dkh(v=vs.80).aspx
Reading that document, I think you're much much better off just
implementing your own versons of _return_value(), _push_dummy_call()
for Windows. The complication of "classifying" the parameters makes
very little sense on Windows, and the hookds you're adding (and that
have been added in the past) only complicate the generic ABI code.
next prev parent reply other threads:[~2012-10-25 13:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 17:23 Joel Brobecker
2012-10-24 17:23 ` [RFA 2/2] amd64-windows: Arguments passed by pointer Joel Brobecker
2012-10-24 17:24 ` [RFA 1/2] Revert "amd64-windows: memory args passed by pointer during function calls." Joel Brobecker
2012-10-25 13:18 ` Mark Kettenis [this message]
2013-01-16 11:59 ` amd64-windows: Fix funcall with by-pointer arguments Joel Brobecker
2013-09-13 22:11 ` [RFC-v2] " Pierre Muller
2013-09-16 20:57 ` Joel Brobecker
2013-09-17 13:50 ` Joel Brobecker
2013-09-20 23:20 ` Joel Brobecker
2013-09-24 16:33 ` Joel Brobecker
2013-09-24 16:33 ` [commit 3/4] Revert use of memory_args_by_pointer in i386 gdbarch_tdep Joel Brobecker
2013-09-24 16:33 ` [commit 2/4] Revert use of integer_param_regs_saved_in_caller_frame " Joel Brobecker
2013-09-24 16:33 ` [commit 1/4] Reimplement function calls on amd64-windows Joel Brobecker
2013-09-24 17:26 ` fixed ChangeLog: " Joel Brobecker
2013-09-24 16:33 ` [commit 4/4] Revert use of classify callback in i386 gdbarch_tdep Joel Brobecker
2013-09-24 16:53 ` [RFC-v2] amd64-windows: Fix funcall with by-pointer arguments Mark Kettenis
2013-09-24 22:02 ` Pierre Muller
2013-09-26 0:34 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210251317.q9PDHrnJ026193@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox