[patch v6 0/3] remove-symbol-file

[Nicolas Blanc <nicolas.blanc@intel.com>]

Hi,


Please see the new command syntax, which was changed according to the feedback
from Doug and Luis (http://sourceware.org/ml/gdb-patches/2013-06/msg00027.html).

Thank you,

Nicolas

Changes between v5 and v6:

* Changed syntax of the command according to feedback:
    remove-symbol-file FILENAME
    remove-symbol-file -a ADDRESS

* Updated the documentation for the new syntax.

* Updated the test for the new syntax.

* Added check to only remove objfiles from the current program space.

Changes between v4 and v5:

* The address parameter can now be any address mapping into one of the sections
  of the file to remove. This is more flexible and more judicious because the symbol
  file may have no text section, as pointed out in some reviews.

* Move is_addr_in_objfile from breakpoint.c to objfiles.c. This new function
  is now used in both symfile.c and breakpoint.c.

* is_addr_in_objfile returns now 0 if OBJFILE is NULL.

* Updated the documentation to reflect the command change.

* Removed double blank lines.

* Reworded the log entries in the commit messages, as suggested.

* The test was simplified using prepare_for_testing, as suggested.

Changes between v3 and v4:

* gdb/symfile.c: add missing space character in output string.

* gdb/doc/gdb.texinfo: add usage example.

Changes between v2 and v3:

* gdb/breakpoints.c (disable_breakpoints_in_freed_objfile):
  Changed name of disable_breakpoints_in_free_objfile to disable_breakpoints_in_freed_objfile.
  Call observer_breakpoint_modified at most one time per breakpoint.

* gdb/objfiles.h (struct objfile): Add comment for low_addr.

* gdb/solib.c (remove_user_added_objfile): Don't check OBJF_SHARED anymore to avoid leaving dangling pointers.

* gdb/symfile.c (add_symbol_file_command): Parse and evaluate the address parameter only once.

* gdb/symfile.c (remove_symbol_file_command): Don't use gdb_buildargv anymore. Ask the user for confirmation before removing a file.

* gdb/doc/gdb.texinfo: The parameter of the command is now referred to as "the address of the text section".

* gdb/NEWS: Move the entry for remove-symbol-file to "Changes since GDB 7.6". The address parameter is now referred to as "the beginning of the text section".

* Fixed letter case of variables in comments.

* Fixed indentation typos.


Nicolas Blanc (3):
  New remove-symbol-file command.
  Test adding and removing a symbol file at runtime.
  Documentation for the remove-symbol-file command.

 gdb/NEWS                               |    6 +
 gdb/breakpoint.c                       |   66 ++++++-
 gdb/doc/gdb.texinfo                    |   26 ++-
 gdb/doc/observer.texi                  |    4 +
 gdb/objfiles.c                         |   23 ++
 gdb/objfiles.h                         |    2 +
 gdb/printcmd.c                         |   15 +-
 gdb/solib.c                            |   22 ++
 gdb/symfile.c                          |   84 ++++++++
 gdb/testsuite/gdb.base/sym-file-lib.c  |   19 ++
 gdb/testsuite/gdb.base/sym-file-main.c |  365 ++++++++++++++++++++++++++++++++
 gdb/testsuite/gdb.base/sym-file.exp    |  143 +++++++++++++
 12 files changed, 764 insertions(+), 11 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/sym-file-lib.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file-main.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file.exp

-- 
1.7.6.5