Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: Nicolas Blanc <nicolas.blanc@intel.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com, tromey@redhat.com,
	 eliz@gnu.org, yao@codesourcery.com, dje@google.com
Subject: Re: [patch v6 3/3] Documentation for the remove-symbol-file command.
Date: Thu, 06 Jun 2013 15:49:00 -0000	[thread overview]
Message-ID: <51B0AF88.7090909@codesourcery.com> (raw)
In-Reply-To: <1370459252-24643-4-git-send-email-nicolas.blanc@intel.com>

Thanks.

On 06/05/2013 09:07 PM, Nicolas Blanc wrote:
> 2013-04-05  Nicolas Blanc  <nicolas.blanc@intel.com>
>
> 	* NEWS: Add description of the remove-symbol-file command.
> gdb/doc
> 	* gdb.texinfo (Commands to Specify Files): Add description
> 	of the remove-symbol-file command.
>
> Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
> ---
>   gdb/NEWS            |    6 ++++++
>   gdb/doc/gdb.texinfo |   26 ++++++++++++++++++++++++--
>   2 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index eea9917..311a164 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -31,6 +31,12 @@ maint set|show per-command time
>   maint set|show per-command symtab
>     Enable display of per-command gdb resource usage.
>
> +remove-symbol-file FILENAME
> +remove-symbol-file -a ADDRESS
> +  Remove a symbol file added via add-symbol-file.  The file to remove
> +  can be identified by its filename or by an address pointing inside
> +  one of its sections.
> +

I'd rewrite this one to read a little better. Eli may have a better 
suggestion.

Something like this?

Remove a symbol file added via add-symbol-file.  The symbol file to 
remove can be identified by its filename or by an address that lies 
within the boundaries of this symbol file in memory.

>   * New options
>
>   set remote trace-status-packet
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index e9b6eae..222d4bd 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -16511,8 +16511,9 @@ section name and base address for that section.  You can specify any
>   The symbol table of the file @var{filename} is added to the symbol table
>   originally read with the @code{symbol-file} command.  You can use the
>   @code{add-symbol-file} command any number of times; the new symbol data
> -thus read keeps adding to the old.  To discard all old symbol data
> -instead, use the @code{symbol-file} command without any arguments.
> +thus read keeps adding to the old.
> +
> +Changes can be reverted using the command @code{remove-symbol-file}.
>
>   @cindex relocatable object files, reading symbols from
>   @cindex object files, relocatable, reading symbols from
> @@ -16550,6 +16551,27 @@ way.
>
>   @code{add-symbol-file} does not repeat if you press @key{RET} after using it.
>
> +@kindex remove-symbol-file
> +@item remove-symbol-file @var{filename}
> +@item remove-symbol-file -a @var{address}
> +Remove a symbol file added via the @code{add-symbol-file} command.  The
> +file to remove can be identified by its filename or by an address pointing
> +inside one of its sections. Example:

Same as above?


  reply	other threads:[~2013-06-06 15:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 19:08 [patch v6 0/3] remove-symbol-file Nicolas Blanc
2013-06-05 19:08 ` [patch v6 2/3] Test adding and removing a symbol file at runtime Nicolas Blanc
2013-06-06 15:47   ` Luis Machado
2013-06-05 19:08 ` [patch v6 1/3] New remove-symbol-file command Nicolas Blanc
2013-06-06 15:44   ` Luis Machado
2013-06-05 19:08 ` [patch v6 3/3] Documentation for the " Nicolas Blanc
2013-06-06 15:49   ` Luis Machado [this message]
2013-06-06 16:17     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B0AF88.7090909@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nicolas.blanc@intel.com \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox