From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7762 invoked by alias); 5 Jun 2013 19:08:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7748 invoked by uid 89); 5 Jun 2013 19:08:11 -0000 X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,TW_BJ,TW_RG autolearn=ham version=3.3.1 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 05 Jun 2013 19:08:10 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 05 Jun 2013 12:08:08 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga001.jf.intel.com with ESMTP; 05 Jun 2013 12:08:06 -0700 Received: from ulslx001.iul.intel.com (ulslx001.iul.intel.com [172.28.207.63]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id r55J85br029033; Wed, 5 Jun 2013 20:08:05 +0100 Received: from ulslx001.iul.intel.com (localhost [127.0.0.1]) by ulslx001.iul.intel.com with ESMTP id r55J85KZ024684; Wed, 5 Jun 2013 21:08:05 +0200 Received: (from nblanc@localhost) by ulslx001.iul.intel.com with id r55J83ld024680; Wed, 5 Jun 2013 21:08:03 +0200 From: Nicolas Blanc To: gdb-patches@sourceware.org, palves@redhat.com, tromey@redhat.com, eliz@gnu.org, yao@codesourcery.com, lgustavo@codesourcery.com, dje@google.com Cc: nicolas.blanc@intel.com Subject: [patch v6 0/3] remove-symbol-file Date: Wed, 05 Jun 2013 19:08:00 -0000 Message-Id: <1370459252-24643-1-git-send-email-nicolas.blanc@intel.com> X-SW-Source: 2013-06/txt/msg00091.txt.bz2 Hi, Please see the new command syntax, which was changed according to the feedback from Doug and Luis (http://sourceware.org/ml/gdb-patches/2013-06/msg00027.html). Thank you, Nicolas Changes between v5 and v6: * Changed syntax of the command according to feedback: remove-symbol-file FILENAME remove-symbol-file -a ADDRESS * Updated the documentation for the new syntax. * Updated the test for the new syntax. * Added check to only remove objfiles from the current program space. Changes between v4 and v5: * The address parameter can now be any address mapping into one of the sections of the file to remove. This is more flexible and more judicious because the symbol file may have no text section, as pointed out in some reviews. * Move is_addr_in_objfile from breakpoint.c to objfiles.c. This new function is now used in both symfile.c and breakpoint.c. * is_addr_in_objfile returns now 0 if OBJFILE is NULL. * Updated the documentation to reflect the command change. * Removed double blank lines. * Reworded the log entries in the commit messages, as suggested. * The test was simplified using prepare_for_testing, as suggested. Changes between v3 and v4: * gdb/symfile.c: add missing space character in output string. * gdb/doc/gdb.texinfo: add usage example. Changes between v2 and v3: * gdb/breakpoints.c (disable_breakpoints_in_freed_objfile): Changed name of disable_breakpoints_in_free_objfile to disable_breakpoints_in_freed_objfile. Call observer_breakpoint_modified at most one time per breakpoint. * gdb/objfiles.h (struct objfile): Add comment for low_addr. * gdb/solib.c (remove_user_added_objfile): Don't check OBJF_SHARED anymore to avoid leaving dangling pointers. * gdb/symfile.c (add_symbol_file_command): Parse and evaluate the address parameter only once. * gdb/symfile.c (remove_symbol_file_command): Don't use gdb_buildargv anymore. Ask the user for confirmation before removing a file. * gdb/doc/gdb.texinfo: The parameter of the command is now referred to as "the address of the text section". * gdb/NEWS: Move the entry for remove-symbol-file to "Changes since GDB 7.6". The address parameter is now referred to as "the beginning of the text section". * Fixed letter case of variables in comments. * Fixed indentation typos. Nicolas Blanc (3): New remove-symbol-file command. Test adding and removing a symbol file at runtime. Documentation for the remove-symbol-file command. gdb/NEWS | 6 + gdb/breakpoint.c | 66 ++++++- gdb/doc/gdb.texinfo | 26 ++- gdb/doc/observer.texi | 4 + gdb/objfiles.c | 23 ++ gdb/objfiles.h | 2 + gdb/printcmd.c | 15 +- gdb/solib.c | 22 ++ gdb/symfile.c | 84 ++++++++ gdb/testsuite/gdb.base/sym-file-lib.c | 19 ++ gdb/testsuite/gdb.base/sym-file-main.c | 365 ++++++++++++++++++++++++++++++++ gdb/testsuite/gdb.base/sym-file.exp | 143 +++++++++++++ 12 files changed, 764 insertions(+), 11 deletions(-) create mode 100644 gdb/testsuite/gdb.base/sym-file-lib.c create mode 100644 gdb/testsuite/gdb.base/sym-file-main.c create mode 100644 gdb/testsuite/gdb.base/sym-file.exp -- 1.7.6.5