From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Remove redundant condition checking.
Date: Tue, 15 Jan 2013 09:35:00 -0000 [thread overview]
Message-ID: <1358242481-16288-1-git-send-email-yao@codesourcery.com> (raw)
Hi,
Just find here is another redundant checking,
if (lwp->bp_reinsert != 0) <-- [1]
{
if (debug_threads)
fprintf (stderr, " pending reinsert at 0x%s\n",
paddress (lwp->bp_reinsert));
if (lwp->bp_reinsert != 0 && can_hardware_single_step ()) <-- [2]
This patch is to remove the redundant one in [2].
gdb/gdbserver:
2013-01-15 Yao Qi <yao@codesourcery.com>
* linux-low.c (linux_resume_one_lwp): Don't check
'(lwp->bp_reinsert != 0'.
---
gdb/gdbserver/linux-low.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 89988eb..8988509 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -3192,7 +3192,7 @@ linux_resume_one_lwp (struct lwp_info *lwp,
fprintf (stderr, " pending reinsert at 0x%s\n",
paddress (lwp->bp_reinsert));
- if (lwp->bp_reinsert != 0 && can_hardware_single_step ())
+ if (can_hardware_single_step ())
{
if (fast_tp_collecting == 0)
{
--
1.7.7.6
next reply other threads:[~2013-01-15 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 9:35 Yao Qi [this message]
2013-01-15 21:19 ` Pedro Alves
2013-01-15 21:20 ` Pedro Alves
2013-01-16 14:47 ` committed: " Yao Qi
-- strict thread matches above, loose matches on Subject: below --
2013-01-15 9:31 Yao Qi
2013-01-15 14:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358242481-16288-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox