From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove redundant condition checking.
Date: Tue, 15 Jan 2013 14:38:00 -0000 [thread overview]
Message-ID: <50F569BE.9010708@redhat.com> (raw)
In-Reply-To: <1358242261-16209-1-git-send-email-yao@codesourcery.com>
On 01/15/2013 09:31 AM, Yao Qi wrote:
> The condition '!single_inst' is checked in both [1] and [2], but the
> checking in [2] is not necessary. This patch is to remove the
> checking in [2], because I don't see keep it in [2] helps
> understanding the code. It is obvious to me, but the review is still
> welcome.
Yes, certainly fine.
> * infcmd.c (step_once): Don't check '!single_inst' as it was
> check before.
"was checked".
--
Pedro Alves
next prev parent reply other threads:[~2013-01-15 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 9:31 Yao Qi
2013-01-15 14:38 ` Pedro Alves [this message]
2013-01-16 14:48 ` committed: " Yao Qi
2013-01-15 9:35 Yao Qi
2013-01-15 21:19 ` Pedro Alves
2013-01-15 21:20 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F569BE.9010708@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox