[PATCH 2/2]: Fix clean compile on AIX 5.3

[PATCH 2/2]: Fix clean compile on AIX 5.3

[Chris January]

AIX curses doesn't define 'clear'. It should be #define clear()
wclear(stdscr), but this is missing from the headers. It can be worked
around by using erase and clearok, or maybe there is a better way?

2012-03-12  Chris January  <chris.january@allinea.com>

        * tui-tui.win.c (tui_resize_all): Use erase and clearok instead 
        of clear.
---
diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index b48bf3e..d02cd7a 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -693,7 +693,8 @@ tui_resize_all (void)
 	    cmd_split_diff++;
 	}
       /* Now adjust each window.  */
-      clear ();
+      erase ();
+      clearok (curscr, TRUE);
       refresh ();
       switch (cur_layout)
 	{

Re: [PATCH 2/2]: Fix clean compile on AIX 5.3

[Joel Brobecker]

> AIX curses doesn't define 'clear'. It should be #define clear()
> wclear(stdscr), but this is missing from the headers. It can be worked
> around by using erase and clearok, or maybe there is a better way?
> 
> 2012-03-12  Chris January  <chris.january@allinea.com>
> 
>         * tui-tui.win.c (tui_resize_all): Use erase and clearok instead 
>         of clear.

I cannot help on this one, because I don't know curses much.  But
I noticed that the filename in the ChangeLog entry was mistyped.

I would have also used a different subject, because some of the Global
Maintainers might skip this patch and leave it to me simply because
it is "AIX"...  I suggest you send an email to cancel this patch/thread,
and send a new one with "TUI" in the subject.

> ---
> diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
> index b48bf3e..d02cd7a 100644
> --- a/gdb/tui/tui-win.c
> +++ b/gdb/tui/tui-win.c
> @@ -693,7 +693,8 @@ tui_resize_all (void)
>  	    cmd_split_diff++;
>  	}
>        /* Now adjust each window.  */
> -      clear ();
> +      erase ();
> +      clearok (curscr, TRUE);
>        refresh ();
>        switch (cur_layout)
>  	{
> 

-- 
Joel

Re: [PATCH 2/2]: Fix clean compile on AIX 5.3

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I cannot help on this one, because I don't know curses much.  But
Joel> I noticed that the filename in the ChangeLog entry was mistyped.

Me neither really, but a little reading convinced me that clear == erase
+ clearok; so this patch is ok.

Tom

Re: [PATCH 2/2]: Fix clean compile on AIX 5.3

[Joel Brobecker]

> Me neither really, but a little reading convinced me that clear == erase
> + clearok; so this patch is ok.

Perhaps a quick comment explaining that the two calls should not be
replaced by a "straightforward" call to "clear"?

-- 
Joel

Re: [PATCH 2/2]: Fix clean compile on AIX 5.3

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> Me neither really, but a little reading convinced me that clear == erase
>> + clearok; so this patch is ok.

Joel> Perhaps a quick comment explaining that the two calls should not be
Joel> replaced by a "straightforward" call to "clear"?

Seems smart to me.

Tom

Re: [PATCH 2/2]: Fix clean compile on AIX 5.3

[Chris January]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

On Mon, 2012-03-12 at 13:52 -0700, Joel Brobecker wrote:
> > Me neither really, but a little reading convinced me that clear == erase
> > + clearok; so this patch is ok.
> 
> Perhaps a quick comment explaining that the two calls should not be
> replaced by a "straightforward" call to "clear"?

Done. New patch attached.

[-- Attachment #2: aix-compile-2.patch --]
[-- Type: text/x-patch, Size: 489 bytes --]

diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index b48bf3e..ea868c6 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -693,7 +693,10 @@ tui_resize_all (void)
            cmd_split_diff++;
        }
       /* Now adjust each window.  */
-      clear ();
+      /* erase + clearok are used instead of a straightforward clear as
+         AIX 5.3 does not define clear.  */
+      erase ();
+      clearok (curscr, TRUE);
       refresh ();
       switch (cur_layout)
        {

Re: [PATCH 2/2]: Fix clean compile on AIX 5.3

[Tom Tromey]

>>>>> "Chris" == Chris January <chris.january@allinea.com> writes:

Joel> Perhaps a quick comment explaining that the two calls should not be
Joel> replaced by a "straightforward" call to "clear"?

Chris> Done. New patch attached.

I checked it in.

Tom