Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Chris January <chris.january@allinea.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2]: Fix clean compile on AIX 5.3
Date: Mon, 12 Mar 2012 16:02:00 -0000	[thread overview]
Message-ID: <20120312160145.GM2853@adacore.com> (raw)
In-Reply-To: <1331553669.2783.18.camel@gumtree>

> AIX curses doesn't define 'clear'. It should be #define clear()
> wclear(stdscr), but this is missing from the headers. It can be worked
> around by using erase and clearok, or maybe there is a better way?
> 
> 2012-03-12  Chris January  <chris.january@allinea.com>
> 
>         * tui-tui.win.c (tui_resize_all): Use erase and clearok instead 
>         of clear.

I cannot help on this one, because I don't know curses much.  But
I noticed that the filename in the ChangeLog entry was mistyped.

I would have also used a different subject, because some of the Global
Maintainers might skip this patch and leave it to me simply because
it is "AIX"...  I suggest you send an email to cancel this patch/thread,
and send a new one with "TUI" in the subject.

> ---
> diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
> index b48bf3e..d02cd7a 100644
> --- a/gdb/tui/tui-win.c
> +++ b/gdb/tui/tui-win.c
> @@ -693,7 +693,8 @@ tui_resize_all (void)
>  	    cmd_split_diff++;
>  	}
>        /* Now adjust each window.  */
> -      clear ();
> +      erase ();
> +      clearok (curscr, TRUE);
>        refresh ();
>        switch (cur_layout)
>  	{
> 

-- 
Joel


  reply	other threads:[~2012-03-12 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 12:01 Chris January
2012-03-12 16:02 ` Joel Brobecker [this message]
2012-03-12 19:50   ` Tom Tromey
2012-03-12 20:52     ` Joel Brobecker
2012-03-12 21:04       ` Tom Tromey
2012-03-16 11:25       ` Chris January
2012-03-16 18:22         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312160145.GM2853@adacore.com \
    --to=brobecker@adacore.com \
    --cc=chris.january@allinea.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox