Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [commit] Fix thinko in help of "set breakpoint condition-evaluation".
@ 2012-03-08 16:51 Joel Brobecker
  2012-03-08 21:02 ` Luis Gustavo
  0 siblings, 1 reply; 2+ messages in thread
From: Joel Brobecker @ 2012-03-08 16:51 UTC (permalink / raw)
  To: gdb-patches; +Cc: Joel Brobecker

FYI, I checked in the following patch.

The 3 valid values for this setting are "auto", "host" and "target".
The help was advertising one of them to be "gdb" instead of "host".

gdb/ChangeLog:

        * breakpoint.c (_initialize_breakpoint): Fix error in help of
        "set breakpoint condition-evaluation" command.

Tested by rebuilding GDB on x86_64-linux.

---
 gdb/ChangeLog    |    5 +++++
 gdb/breakpoint.c |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0964c5f..ad99b61 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-08  Joel Brobecker  <brobecker@adacore.com>
+
+	* breakpoint.c (_initialize_breakpoint): Fix error in help of
+	"set breakpoint condition-evaluation" command.
+
 2012-03-08  Tristan Gingold  <gingold@adacore.com>
 
 	* sparc-stub.c: Move to stubs/
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 5388a4e..1158f0e 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -15517,7 +15517,7 @@ inferior in all-stop mode, gdb behaves as if always-inserted mode is off."),
 			&condition_evaluation_mode_1, _("\
 Set mode of breakpoint condition evaluation."), _("\
 Show mode of breakpoint condition evaluation."), _("\
-When this is set to \"gdb\", breakpoint conditions will be\n\
+When this is set to \"host\", breakpoint conditions will be\n\
 evaluated on the host's side by GDB.  When it is set to \"target\",\n\
 breakpoint conditions will be downloaded to the target (if the target\n\
 supports such feature) and conditions will be evaluated on the target's side.\n\
-- 
1.7.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [commit] Fix thinko in help of "set breakpoint condition-evaluation".
  2012-03-08 16:51 [commit] Fix thinko in help of "set breakpoint condition-evaluation" Joel Brobecker
@ 2012-03-08 21:02 ` Luis Gustavo
  0 siblings, 0 replies; 2+ messages in thread
From: Luis Gustavo @ 2012-03-08 21:02 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

Thanks! I changed this a few times and ended up missing a few spots in 
the last update.

Luis
On 03/08/2012 01:51 PM, Joel Brobecker wrote:
> FYI, I checked in the following patch.
>
> The 3 valid values for this setting are "auto", "host" and "target".
> The help was advertising one of them to be "gdb" instead of "host".
>
> gdb/ChangeLog:
>
>          * breakpoint.c (_initialize_breakpoint): Fix error in help of
>          "set breakpoint condition-evaluation" command.
>
> Tested by rebuilding GDB on x86_64-linux.
>
> ---
>   gdb/ChangeLog    |    5 +++++
>   gdb/breakpoint.c |    2 +-
>   2 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 0964c5f..ad99b61 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-03-08  Joel Brobecker<brobecker@adacore.com>
> +
> +	* breakpoint.c (_initialize_breakpoint): Fix error in help of
> +	"set breakpoint condition-evaluation" command.
> +
>   2012-03-08  Tristan Gingold<gingold@adacore.com>
>
>   	* sparc-stub.c: Move to stubs/
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 5388a4e..1158f0e 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -15517,7 +15517,7 @@ inferior in all-stop mode, gdb behaves as if always-inserted mode is off."),
>   			&condition_evaluation_mode_1, _("\
>   Set mode of breakpoint condition evaluation."), _("\
>   Show mode of breakpoint condition evaluation."), _("\
> -When this is set to \"gdb\", breakpoint conditions will be\n\
> +When this is set to \"host\", breakpoint conditions will be\n\
>   evaluated on the host's side by GDB.  When it is set to \"target\",\n\
>   breakpoint conditions will be downloaded to the target (if the target\n\
>   supports such feature) and conditions will be evaluated on the target's side.\n\


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-08 21:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-08 16:51 [commit] Fix thinko in help of "set breakpoint condition-evaluation" Joel Brobecker
2012-03-08 21:02 ` Luis Gustavo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox