From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29617 invoked by alias); 8 Mar 2012 21:02:31 -0000 Received: (qmail 29609 invoked by uid 22791); 8 Mar 2012 21:02:29 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 21:02:16 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1S5kTX-0002bm-Fg from Luis_Gustavo@mentor.com ; Thu, 08 Mar 2012 13:02:15 -0800 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 8 Mar 2012 13:02:01 -0800 Received: from [0.0.0.0] ([172.16.63.104]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 8 Mar 2012 13:02:14 -0800 Message-ID: <4F591E57.9000200@mentor.com> Date: Thu, 08 Mar 2012 21:02:00 -0000 From: Luis Gustavo Reply-To: "Gustavo, Luis" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.27) Gecko/20120216 Lightning/1.0b2 Thunderbird/3.1.19 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [commit] Fix thinko in help of "set breakpoint condition-evaluation". References: <1331225474-4760-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1331225474-4760-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00288.txt.bz2 Thanks! I changed this a few times and ended up missing a few spots in the last update. Luis On 03/08/2012 01:51 PM, Joel Brobecker wrote: > FYI, I checked in the following patch. > > The 3 valid values for this setting are "auto", "host" and "target". > The help was advertising one of them to be "gdb" instead of "host". > > gdb/ChangeLog: > > * breakpoint.c (_initialize_breakpoint): Fix error in help of > "set breakpoint condition-evaluation" command. > > Tested by rebuilding GDB on x86_64-linux. > > --- > gdb/ChangeLog | 5 +++++ > gdb/breakpoint.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 0964c5f..ad99b61 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2012-03-08 Joel Brobecker > + > + * breakpoint.c (_initialize_breakpoint): Fix error in help of > + "set breakpoint condition-evaluation" command. > + > 2012-03-08 Tristan Gingold > > * sparc-stub.c: Move to stubs/ > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 5388a4e..1158f0e 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -15517,7 +15517,7 @@ inferior in all-stop mode, gdb behaves as if always-inserted mode is off."), > &condition_evaluation_mode_1, _("\ > Set mode of breakpoint condition evaluation."), _("\ > Show mode of breakpoint condition evaluation."), _("\ > -When this is set to \"gdb\", breakpoint conditions will be\n\ > +When this is set to \"host\", breakpoint conditions will be\n\ > evaluated on the host's side by GDB. When it is set to \"target\",\n\ > breakpoint conditions will be downloaded to the target (if the target\n\ > supports such feature) and conditions will be evaluated on the target's side.\n\