[PATCH] testsuite: altivec-abi.exp: remove obsolete parameter

[PATCH] testsuite: altivec-abi.exp: remove obsolete parameter

[Edjunior Barbosa Machado]

Hi,

the current version of gdb.arch/altivec-abi.exp is crashing on ppc64 with
the following:

Running ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp ...
ERROR: tcl error sourcing ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp.
ERROR: wrong # args: should be "altivec_abi_tests prefix extra_flags force_abi"
    while executing
"altivec_abi_tests  "additional_flags=-maltivec" "auto""
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $body"
    invoked from within
"with_test_prefix "default ABI, auto" {
	altivec_abi_tests  "additional_flags=-maltivec" "auto"
    }"
    invoked from within
"if [test_compiler_info gcc*] {
    with_test_prefix "default ABI, auto" {
	altivec_abi_tests  "additional_flags=-maltivec" "auto"
    }

    # On GNU/..."
    (file "../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp" line 149)
    invoked from within
"source ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""

The patch below fixes this issue removing the no longer used parameter 'prefix'
from altivec_abi_tests.

Thanks,
--
Edjunior

gdb/testsuite/
2012-03-02  Edjunior Machado  <emachado@linux.vnet.ibm.com>

	* gdb.arch/altivec-abi.exp (altivec_abi_tests): Remove obsolete
	parameter.

diff --git a/gdb/testsuite/gdb.arch/altivec-abi.exp b/gdb/testsuite/gdb.arch/altivec-abi.exp
index 718018d..74b8f2a 100644
--- a/gdb/testsuite/gdb.arch/altivec-abi.exp
+++ b/gdb/testsuite/gdb.arch/altivec-abi.exp
@@ -36,7 +36,7 @@ if [get_compiler_info $binfile] {
     return -1
 }
 
-proc altivec_abi_tests { prefix extra_flags force_abi } {
+proc altivec_abi_tests { extra_flags force_abi } {
     global testfile binfile srcfile srcdir subdir
     global gdb_prompt
 

Re: [PATCH] testsuite: altivec-abi.exp: remove obsolete parameter

[Pedro Alves]

On 03/02/2012 05:55 PM, Edjunior Barbosa Machado wrote:

> The patch below fixes this issue removing the no longer used parameter 'prefix'
> from altivec_abi_tests.

I left it behind with the with_test_prefix changes, but I meant to remove it.
Sorry about that.  Please go ahead and check this in.

-- 
Pedro Alves

Re: [PATCH] testsuite: altivec-abi.exp: remove obsolete parameter

[Edjunior Barbosa Machado]

On 03/02/2012 03:10 PM, Pedro Alves wrote:

> On 03/02/2012 05:55 PM, Edjunior Barbosa Machado wrote:
> 
>> The patch below fixes this issue removing the no longer used parameter 'prefix'
>> from altivec_abi_tests.
> 
> I left it behind with the with_test_prefix changes, but I meant to remove it.
> Sorry about that.  Please go ahead and check this in.
> 


Thanks, Pedro. I've just checked this in:

	http://sourceware.org/ml/gdb-cvs/2012-03/msg00056.html

-- 
Edjunior