Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] testsuite: altivec-abi.exp: remove obsolete parameter
Date: Fri, 02 Mar 2012 17:56:00 -0000	[thread overview]
Message-ID: <1330710919-8717-1-git-send-email-emachado@linux.vnet.ibm.com> (raw)

Hi,

the current version of gdb.arch/altivec-abi.exp is crashing on ppc64 with
the following:

Running ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp ...
ERROR: tcl error sourcing ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp.
ERROR: wrong # args: should be "altivec_abi_tests prefix extra_flags force_abi"
    while executing
"altivec_abi_tests  "additional_flags=-maltivec" "auto""
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $body"
    invoked from within
"with_test_prefix "default ABI, auto" {
	altivec_abi_tests  "additional_flags=-maltivec" "auto"
    }"
    invoked from within
"if [test_compiler_info gcc*] {
    with_test_prefix "default ABI, auto" {
	altivec_abi_tests  "additional_flags=-maltivec" "auto"
    }

    # On GNU/..."
    (file "../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp" line 149)
    invoked from within
"source ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source ../../../gdb.git/gdb/testsuite/gdb.arch/altivec-abi.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""

The patch below fixes this issue removing the no longer used parameter 'prefix'
from altivec_abi_tests.

Thanks,
--
Edjunior

gdb/testsuite/
2012-03-02  Edjunior Machado  <emachado@linux.vnet.ibm.com>

	* gdb.arch/altivec-abi.exp (altivec_abi_tests): Remove obsolete
	parameter.

diff --git a/gdb/testsuite/gdb.arch/altivec-abi.exp b/gdb/testsuite/gdb.arch/altivec-abi.exp
index 718018d..74b8f2a 100644
--- a/gdb/testsuite/gdb.arch/altivec-abi.exp
+++ b/gdb/testsuite/gdb.arch/altivec-abi.exp
@@ -36,7 +36,7 @@ if [get_compiler_info $binfile] {
     return -1
 }
 
-proc altivec_abi_tests { prefix extra_flags force_abi } {
+proc altivec_abi_tests { extra_flags force_abi } {
     global testfile binfile srcfile srcdir subdir
     global gdb_prompt
 


             reply	other threads:[~2012-03-02 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 17:56 Edjunior Barbosa Machado [this message]
2012-03-02 18:11 ` Pedro Alves
2012-03-02 18:51   ` Edjunior Barbosa Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330710919-8717-1-git-send-email-emachado@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox