From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simark@simark.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Remove call of GenerateConsoleCtrlEvent
Date: Thu, 24 Sep 2020 15:01:07 +0000 (UTC) [thread overview]
Message-ID: <1323262264.565685.1600959667658@mail.yahoo.com> (raw)
In-Reply-To: <83v9g3tezj.fsf@gnu.org>
Am Donnerstag, 24. September 2020, 16:40:27 MESZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben:
> > From: Simon Marchi <simark@simark.ca>
> > Date: Wed, 23 Sep 2020 23:35:10 -0400
> >
> > On 2020-09-23 1:21 p.m., Hannes Domani via Gdb-patches wrote:
> > > GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c event was created
> > > in the target process (like if the target doesn't have a console).
> > >
> > > Since this prevents DebugBreakProcess from being called (which should
> > > always work), this removes it.
> >
> > Eli, does that make sense to you? Just judging from the explanation
> > above, it sounds fine to me.
>
> The explanation sounds fine, but I don't know enough about the
> details to say something intelligent. This seems to have some
> non-trivial context that I lack to understand, for example, why the
> fact that "GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c
> event was created in the target process" is a problem.
Because then DebugBreakProcess isn't called, and the target process is
not stopped.
next prev parent reply other threads:[~2020-09-24 15:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200923172122.2089-1-ssbssa.ref@yahoo.de>
2020-09-23 17:21 ` [PATCH 1/3] Handle 64bit breakpoints of WOW64 processes as SIGINT Hannes Domani via Gdb-patches
2020-09-23 17:21 ` [PATCH 2/3] Revert "Fix ctrl-c when debugging WOW64 processes" Hannes Domani via Gdb-patches
2020-09-23 17:21 ` [PATCH 3/3] Remove call of GenerateConsoleCtrlEvent Hannes Domani via Gdb-patches
2020-09-24 3:35 ` Simon Marchi
2020-09-24 14:40 ` Eli Zaretskii via Gdb-patches
2020-09-24 15:01 ` Hannes Domani via Gdb-patches [this message]
2020-09-24 3:30 ` [PATCH 1/3] Handle 64bit breakpoints of WOW64 processes as SIGINT Simon Marchi
2020-09-24 15:26 ` Hannes Domani via Gdb-patches
2020-09-24 15:29 ` Simon Marchi
2020-09-24 16:37 ` Hannes Domani via Gdb-patches
2020-09-24 16:42 ` Simon Marchi
2020-09-24 17:05 ` Hannes Domani via Gdb-patches
2020-09-24 17:22 ` Joel Brobecker
2020-09-24 17:51 ` Hannes Domani via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323262264.565685.1600959667658@mail.yahoo.com \
--to=gdb-patches@sourceware.org \
--cc=eliz@gnu.org \
--cc=simark@simark.ca \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox