From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0LTeLcK0bF/xfgAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 11:01:22 -0400 Received: by simark.ca (Postfix, from userid 112) id B7B531EE05; Thu, 24 Sep 2020 11:01:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68A8B1E509 for ; Thu, 24 Sep 2020 11:01:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B85513857C52; Thu, 24 Sep 2020 15:01:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B85513857C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1600959681; bh=KbnnZTGSNadZKhE58dWwtJNW3SQz1Hq0OabyYEAtYUs=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VpKPWh6gS3d4p8vC5I4RpVpYRW0vKMJtzV7TeAMpGbpHgtJ+kNNw38z8s4nrLRE4J lHdtPP2Hd5INoBBQhAOoT7y/rDLURE0yPK+wv4WjKTrWOjRAyBMVXo+qINkdxiusf1 yRAi2203J5vUFolTcoc/gcDMkiBouu+18fXXmbmM= Received: from sonic305-20.consmr.mail.ir2.yahoo.com (sonic305-20.consmr.mail.ir2.yahoo.com [77.238.177.82]) by sourceware.org (Postfix) with ESMTPS id 3CD853857C52 for ; Thu, 24 Sep 2020 15:01:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3CD853857C52 X-YMail-OSG: 9TdF0HAVM1nbiKSWEKqv8yKG23fq1FbSYLarepzFRTjbeG6E_haNUksmB.eQNm5 HgHpJODDXt3hZN0yEp6DImhpeT3M8TIFodUGKWDjFjO2qVLSwdII1FPLGPR0yGmuLT9.OUnWpeGB x_laqX4nk58b7x36Anm6slUNWAbfys8vNb6wMRwO8QEkr6aiz0Xu3nTZpGNJwV1w1M.ch0JgpUFw dOeaZnTc4m0hJ6PJ6ckjqNVHD3Ov0fhu0AzrhRTVdpFWLZ8k1ld.iFjpwMo3eey0NGli2xvGmqgq Eh7fztfrvepCtRn4OmLwxLhNl.iNcrIXTCpmJxAd2b1EG9g0wPVF0HxGXnzaiF_dulp72HgMywsH IhMWlpB0ISn4jerwyIAElTshW0KtAYvMEtBx0VOEMseiiAIegxmUnfSvnqsPAxdMQWVXc8OMgjbu FnOmpHv629HxjaIFiXRgs9aosxY8Ov8b11ZxuZpnz4Rw7P3KDuTFROguKBdg5Aw_yDHZ1OgpAzpR LEAUYKuHd6Uf5Z2L47zSpskdcGylJTuPj7ulLC2zmeYnMFGfUWIovaVhn7DDc9U8Of5ysg.seT64 0Y7uPFLlUz3vtsR0SrvHAEJJCSm0EfFewpjK.uPcdA3KzWJ88zUq5zlv4FQxLn95lfZyFuXty4AW XR1hkwGnAp2BGjwLRi3VlhkG03smFarXjhXChQ2cLyTI8o_nCKLjhk94hj_V1YM4p4shducW39nf RqGlVzP1uL1Tiu2uA4B_VRt7hjnSZu5.khffCpmBXNIek26anwJEXQPALnun9w4P7nainRuq4pp1 sRFMZaOY5vavFiD2QjqK4H20VrZEwlvVSJdO0OrvViGN0PIj4gJjv3eySiWOGdm_5NWTGjv4W0ie PdK9UxA4yT_Buft4y5CjqdIhv.oMQvBfRZ291pS0.cNrKOY065mcQCPbc5p_jptZTgZ2mm0v.k4s YyUQDjHObTxRSlRWxpQQqVnA5vnxK9ngj.UEmGMC61iagLNUnKp5RQtdtQoqDpil__ao92vg94Se S0qpbL0vgJaBM4g1PXPwurJXqR5noBldz06nEotiX.h98VW4s3djwWFptipwB5nzeudtEkM_bcwl L.Aup6aC4DlafFCGHH_Er8ghfrV5MM2Xa3OIbMD2djPS7Z6mvlxf5Skcs5XkOgmJ2LKs.CAq4lWn xUSdF6QbGP.kejBkkbkQOFk.Kjx1yG466AkgAog3OhABbaaP5ygskX9hMjOJriN9Vie3Zo5oxXxQ UsTIPCSEI00rGmhGhr83Z1.50nxgZqIh4J6p3hSPAsT4l4TjsZPcGfrp3F00OO4SHGJH4OdEybx5 DgWtArYmJJR2A_66pEOyXC4uHWouliqqtzZYQ86tAHFxQRwV8lcmMoKl.UTyGjb327St_2eLr8yn qU_yeXJM5N7gksPV_4TQzqHWoAkg2wBYGQ1DbO8mtmF9_RD7EBZiwBWGxLgx0tBr3whXlLms4XXG pV_fDIos- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Thu, 24 Sep 2020 15:01:12 +0000 Date: Thu, 24 Sep 2020 15:01:07 +0000 (UTC) To: Simon Marchi , Eli Zaretskii Message-ID: <1323262264.565685.1600959667658@mail.yahoo.com> In-Reply-To: <83v9g3tezj.fsf@gnu.org> References: <20200923172122.2089-1-ssbssa@yahoo.de> <20200923172122.2089-3-ssbssa@yahoo.de> <83v9g3tezj.fsf@gnu.org> Subject: Re: [PATCH 3/3] Remove call of GenerateConsoleCtrlEvent MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.16674 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Donnerstag, 24. September 2020, 16:40:27 MESZ hat Eli Zaretskii Folgendes geschrieben: > > From: Simon Marchi > > Date: Wed, 23 Sep 2020 23:35:10 -0400 > > > > On 2020-09-23 1:21 p.m., Hannes Domani via Gdb-patches wrote: > > > GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c event was cre= ated > > > in the target process (like if the target doesn't have a console). > > > > > > Since this prevents DebugBreakProcess from being called (which should > > > always work), this removes it. > > > > Eli, does that make sense to you?=C2=A0 Just judging from the explanati= on > > above, it sounds fine to me. > > The explanation sounds fine, but I don't know enough about the > details to say something intelligent.=C2=A0 This seems to have some > non-trivial context that I lack to understand, for example, why the > fact that "GenerateConsoleCtrlEvent returns TRUE even if no ctrl-c > event was created in the target process" is a problem. Because then DebugBreakProcess isn't called, and the target process is not stopped.