[RFA/commit] Delete Makefile.in:INSTALLED_LIBS (unused)

[RFA/commit] Delete Makefile.in:INSTALLED_LIBS (unused)

[Joel Brobecker]

This variable seems to be completely unused...  Any objection if
I delete it?

gdb/ChangeLog:

        * Makefile.in (INSTALLED_LIBS): Delete.

Tested on x86_64-linux.

Thanks,
-- 
Joel

---
 gdb/Makefile.in |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index c6049fa..2d3b3bf 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -472,9 +472,6 @@ INTERNAL_LDFLAGS = $(CFLAGS) $(GLOBAL_CFLAGS) $(MH_LDFLAGS) $(LDFLAGS) $(CONFIG_
 # LIBIBERTY appears twice on purpose.
 # If you have the Cygnus libraries installed,
 # you can use 'CLIBS=$(INSTALLED_LIBS)' 'CDEPS='
-INSTALLED_LIBS=-lbfd -lreadline -lopcodes -liberty -ldecnumber \
-	$(XM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ @PYTHON_LIBS@ \
-	-lintl -liberty $(LIBGNU)
 CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(INTL) $(LIBIBERTY) $(LIBDECNUMBER) \
 	$(XM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ @PYTHON_LIBS@ \
 	$(LIBEXPAT) \
-- 
1.7.1

Re: [RFA/commit] Delete Makefile.in:INSTALLED_LIBS (unused)

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> This variable seems to be completely unused...  Any objection if
Joel> I delete it?

Not from me, but I think you should also delete the immediately
preceding comment:

Joel>  # LIBIBERTY appears twice on purpose.
Joel>  # If you have the Cygnus libraries installed,
Joel>  # you can use 'CLIBS=$(INSTALLED_LIBS)' 'CDEPS='

... at least those last 2 lines, I didn't read upwards to see what else
it says.

Tom

Re: [RFA/commit] Delete Makefile.in:INSTALLED_LIBS (unused)

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

> Not from me, but I think you should also delete the immediately
> preceding comment:
[...]
> ... at least those last 2 lines, I didn't read upwards to see what else
> it says.

Yeah, you're right.  Talk about tunnel vision ;-)

I've looked at what's just above, and also supressed the part about
TM_CLIBS, since we don't use those anymore.  I left the comment about
XM_CLIBS, since a couple of platforms still use them (go32 and Mach?).

This is what I have right now.  I'll confess I am not completely
up to date with the purpose of the XM_CLIBS, so I'm not going to
check this in immediately, in case I made a mistake.

Thanks,
-- 
Joel

[-- Attachment #2: install-libs.diff --]
[-- Type: text/x-diff, Size: 1217 bytes --]

commit 56e7d228ff8ac1d7d019c3f2938aa35f77ae7834
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Sat Jan 22 16:00:40 2011 -0500

    Delete Makefile.in:INSTALLED_LIBS (unused)
    
    gdb/ChangeLog:
    
            * Makefile.in (INSTALLED_LIBS): Delete.  Update comment.

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index c6049fa..26b445a 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -468,13 +468,8 @@ INTERNAL_LDFLAGS = $(CFLAGS) $(GLOBAL_CFLAGS) $(MH_LDFLAGS) $(LDFLAGS) $(CONFIG_
 # it doesn't work, then refer to libiberty.
 
 # Libraries and corresponding dependencies for compiling gdb.
-# {X,T}M_CLIBS, defined in *config files, have host- and target-dependent libs.
+# XM_CLIBS, defined in *config files, have host-dependent libs.
 # LIBIBERTY appears twice on purpose.
-# If you have the Cygnus libraries installed,
-# you can use 'CLIBS=$(INSTALLED_LIBS)' 'CDEPS='
-INSTALLED_LIBS=-lbfd -lreadline -lopcodes -liberty -ldecnumber \
-	$(XM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ @PYTHON_LIBS@ \
-	-lintl -liberty $(LIBGNU)
 CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(INTL) $(LIBIBERTY) $(LIBDECNUMBER) \
 	$(XM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ @PYTHON_LIBS@ \
 	$(LIBEXPAT) \

Re: [RFA/commit] Delete Makefile.in:INSTALLED_LIBS (unused)

[Joel Brobecker]

> commit 56e7d228ff8ac1d7d019c3f2938aa35f77ae7834
> Author: Joel Brobecker <brobecker@adacore.com>
> Date:   Sat Jan 22 16:00:40 2011 -0500
> 
>     Delete Makefile.in:INSTALLED_LIBS (unused)
>     
>     gdb/ChangeLog:
>     
>             * Makefile.in (INSTALLED_LIBS): Delete.  Update comment.

This is now in.  I just realized as I am replying that I said that
I would wait, and I just forgot.  Oh well, if there is a mistake
in the comment, I will either fix it or revert.

-- 
Joel