From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3942 invoked by alias); 21 Feb 2011 09:24:47 -0000 Received: (qmail 3925 invoked by uid 22791); 21 Feb 2011 09:24:45 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 09:24:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AA7552BABFA; Mon, 21 Feb 2011 04:24:38 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 23cBIZwg8vTp; Mon, 21 Feb 2011 04:24:38 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 32B8F2BABDD; Mon, 21 Feb 2011 04:24:38 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 804D81459B0; Mon, 21 Feb 2011 13:24:32 +0400 (RET) Date: Mon, 21 Feb 2011 09:54:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Delete Makefile.in:INSTALLED_LIBS (unused) Message-ID: <20110221092432.GC2600@adacore.com> References: <1297922365-17055-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="uZ3hkaAS1mZxFaxD" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00532.txt.bz2 --uZ3hkaAS1mZxFaxD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 641 > Not from me, but I think you should also delete the immediately > preceding comment: [...] > ... at least those last 2 lines, I didn't read upwards to see what else > it says. Yeah, you're right. Talk about tunnel vision ;-) I've looked at what's just above, and also supressed the part about TM_CLIBS, since we don't use those anymore. I left the comment about XM_CLIBS, since a couple of platforms still use them (go32 and Mach?). This is what I have right now. I'll confess I am not completely up to date with the purpose of the XM_CLIBS, so I'm not going to check this in immediately, in case I made a mistake. Thanks, -- Joel --uZ3hkaAS1mZxFaxD Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="install-libs.diff" Content-length: 1217 commit 56e7d228ff8ac1d7d019c3f2938aa35f77ae7834 Author: Joel Brobecker Date: Sat Jan 22 16:00:40 2011 -0500 Delete Makefile.in:INSTALLED_LIBS (unused) gdb/ChangeLog: * Makefile.in (INSTALLED_LIBS): Delete. Update comment. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index c6049fa..26b445a 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -468,13 +468,8 @@ INTERNAL_LDFLAGS = $(CFLAGS) $(GLOBAL_CFLAGS) $(MH_LDFLAGS) $(LDFLAGS) $(CONFIG_ # it doesn't work, then refer to libiberty. # Libraries and corresponding dependencies for compiling gdb. -# {X,T}M_CLIBS, defined in *config files, have host- and target-dependent libs. +# XM_CLIBS, defined in *config files, have host-dependent libs. # LIBIBERTY appears twice on purpose. -# If you have the Cygnus libraries installed, -# you can use 'CLIBS=$(INSTALLED_LIBS)' 'CDEPS=' -INSTALLED_LIBS=-lbfd -lreadline -lopcodes -liberty -ldecnumber \ - $(XM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ @PYTHON_LIBS@ \ - -lintl -liberty $(LIBGNU) CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(INTL) $(LIBIBERTY) $(LIBDECNUMBER) \ $(XM_CLIBS) $(NAT_CLIBS) $(GDBTKLIBS) @LIBS@ @PYTHON_LIBS@ \ $(LIBEXPAT) \ --uZ3hkaAS1mZxFaxD--